Skip to content
This repository was archived by the owner on Feb 4, 2021. It is now read-only.

Commit bc11be5

Browse files
authored
Merge pull request #57 from gedorinku/improve_profile
プロフィールの項目の追加
2 parents dc4e94d + ed1b413 commit bc11be5

11 files changed

+186
-97
lines changed

api/contribution_conllections.swagger.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,12 @@
163163
},
164164
"profile_scope": {
165165
"$ref": "#/definitions/prolab_accountsProfileScope"
166+
},
167+
"atcoder_user_name": {
168+
"type": "string"
169+
},
170+
"display_name": {
171+
"type": "string"
166172
}
167173
}
168174
}

api/entries.swagger.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,12 @@
196196
},
197197
"profile_scope": {
198198
"$ref": "#/definitions/prolab_accountsProfileScope"
199+
},
200+
"atcoder_user_name": {
201+
"type": "string"
202+
},
203+
"display_name": {
204+
"type": "string"
199205
}
200206
}
201207
}

api/protos/users.proto

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ message User {
7878
string github_user_name = 13;
7979
Department department = 14;
8080
ProfileScope profile_scope = 15;
81+
string atcoder_user_name = 16;
82+
string display_name = 17;
8183
}
8284

8385
enum ProfileScope {
@@ -124,6 +126,8 @@ message UpdateUserProfileRequest {
124126
string github_user_name = 7 [(validator.field) = {regex: "^([a-z\\d]+-)*[a-z\\d]+$", length_lt: 40}];
125127
uint32 department_id = 8;
126128
ProfileScope profile_scope = 9 [(validator.field) = {is_in_enum : true}];
129+
string atcoder_user_name = 10 [(validator.field) = {regex: "^[a-zA-Z][a-zA-Z0-9_]{2,15}$"}];
130+
string display_name = 11 [(validator.field) = {length_lt: 51}];
127131
}
128132

129133
message UpdateUserIconRequest {

api/roles.validator.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/users.pb.go

Lines changed: 131 additions & 93 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/users.swagger.json

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,12 @@
380380
},
381381
"profile_scope": {
382382
"$ref": "#/definitions/prolab_accountsProfileScope"
383+
},
384+
"atcoder_user_name": {
385+
"type": "string"
386+
},
387+
"display_name": {
388+
"type": "string"
383389
}
384390
}
385391
},
@@ -427,6 +433,12 @@
427433
},
428434
"profile_scope": {
429435
"$ref": "#/definitions/prolab_accountsProfileScope"
436+
},
437+
"atcoder_user_name": {
438+
"type": "string"
439+
},
440+
"display_name": {
441+
"type": "string"
430442
}
431443
}
432444
},

api/users.validator.pb.go

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/server/users_server.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,8 @@ func (s *userServiceServerImpl) UpdateUserProfile(ctx context.Context, req *api_
248248
TwitterScreenName: null.StringFrom(req.GetTwitterScreenName()),
249249
GithubUserName: null.StringFrom(req.GetGithubUserName()),
250250
ProfileScope: null.IntFrom(int(req.GetProfileScope())),
251+
AtcoderUserName: null.StringFrom(req.GetAtcoderUserName()),
252+
DisplayName: null.StringFrom(req.GetDisplayName()),
251253
}
252254
if id := req.GetRoleId(); id == 0 {
253255
p.RoleID = null.NewInt64(0, false)
@@ -333,6 +335,8 @@ func userToResponse(user *record.User, includePrivate bool, cfg *config.Config)
333335
u.TwitterScreenName = p.TwitterScreenName.String
334336
u.GithubUserName = p.GithubUserName.String
335337
u.ProfileScope = profileScopeToResponse(model.ProfileScope(p.ProfileScope.Int))
338+
u.AtcoderUserName = p.AtcoderUserName.String
339+
u.DisplayName = p.DisplayName.String
336340

337341
if r := p.R; p.R != nil {
338342
if role := r.Role; role != nil {

db/profiles.schema

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
create_table :profiles, force: :cascade do |t|
22
t.timestamps
3+
t.string :display_name
34
t.text :description, null: false
45
t.integer :grade, null: false
56
t.boolean :left, default: false, null: false
67
t.references :department, foreign_key: true
78
t.references :role, foreign_key: true
89
t.string :twitter_screen_name
910
t.string :github_user_name
11+
t.string :atcoder_user_name
1012
t.integer :profile_scope, defualt: 0
1113
end
1214

infra/record/profiles.go

Lines changed: 12 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

infra/record/profiles_test.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)