From fd1016b02b055a986a2e68859dd855a6f73c88a3 Mon Sep 17 00:00:00 2001 From: Kapil Borle Date: Tue, 23 May 2017 18:51:12 -0700 Subject: [PATCH 1/2] Handle help completion result when null is returned --- src/features/HelpCompletion.ts | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/features/HelpCompletion.ts b/src/features/HelpCompletion.ts index d4bc5f0736..d03d37a67d 100644 --- a/src/features/HelpCompletion.ts +++ b/src/features/HelpCompletion.ts @@ -154,12 +154,7 @@ class HelpCompletionProvider { triggerPosition: triggerStartPos, blockComment: this.triggerFinderBlockComment.found }).then(result => { - if (result === undefined) { - return; - } - - let content = result.content; - if (content === undefined) { + if (result == null || result.content == null) { return; } @@ -169,7 +164,7 @@ class HelpCompletionProvider { // Trim the leading whitespace (used by the rule for indentation) as VSCode takes care of the indentation. // Trim the last empty line and join the strings. - let text = content.map(x => x.trimLeft()).slice(0, -1).join(this.getEOL(doc.eol)); + let text = result.content.map(x => x.trimLeft()).slice(0, -1).join(this.getEOL(doc.eol)); editor.insertSnippet(new SnippetString(text), replaceRange); }); } From 56b2bfa2fb06bae8fe467b892abde83d63df1634 Mon Sep 17 00:00:00 2001 From: Kapil Borle Date: Wed, 24 May 2017 11:59:17 -0700 Subject: [PATCH 2/2] Check document before trigger character for help completion --- src/features/HelpCompletion.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/features/HelpCompletion.ts b/src/features/HelpCompletion.ts index d03d37a67d..f2a5f14e51 100644 --- a/src/features/HelpCompletion.ts +++ b/src/features/HelpCompletion.ts @@ -81,7 +81,9 @@ class TriggerFinder { break; case SearchState.Locked: - if (changeText.length === 1 && changeText[0] === this.triggerCharacters[this.count] && document === this.document) { + if (document === this.document && + changeText.length === 1 && + changeText[0] === this.triggerCharacters[this.count]) { this.count++; if (this.count === this.triggerCharacters.length) { this.state = SearchState.Found;