From 2190690d5ae8eaeeceb2815426ed038f26c95d72 Mon Sep 17 00:00:00 2001 From: SeeminglyScience Date: Tue, 1 Mar 2022 13:54:15 -0500 Subject: [PATCH 1/2] Deprecate `promptToUpdatePackageManagement` Fixes #3858 Also add deprecation messages to other previously deprecated settings --- package.json | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index b403f49871..0f389224c7 100644 --- a/package.json +++ b/package.json @@ -594,7 +594,8 @@ "type": "string", "default": "", "scope": "machine", - "description": "REMOVED. Please use the \"powershell.powerShellDefaultVersion\" setting instead." + "description": "REMOVED. Please use the \"powershell.powerShellDefaultVersion\" setting instead.", + "deprecationMessage": "Please use the \"powershell.powerShellDefaultVersion\" setting instead." }, "powershell.promptToUpdatePowerShell": { "type": "boolean", @@ -604,7 +605,8 @@ "powershell.promptToUpdatePackageManagement": { "type": "boolean", "description": "Specifies whether you should be prompted to update your version of PackageManagement if it's under 1.4.6.", - "default": true + "default": true, + "deprecationMessage": "This prompt has been removed as it's no longer strictly necessary to upgrade the PackageManagement module." }, "powershell.startAsLoginShell.osx": { "type": "boolean", @@ -746,7 +748,8 @@ "powershell.codeFormatting.whitespaceAroundPipe": { "type": "boolean", "default": true, - "description": "REMOVED. Please use the \"powershell.codeFormatting.addWhitespaceAroundPipe\" setting instead. If you've used this setting before, we have moved it for you automatically." + "description": "REMOVED. Please use the \"powershell.codeFormatting.addWhitespaceAroundPipe\" setting instead. If you've used this setting before, we have moved it for you automatically.", + "deprecationMessage": "Please use the \"powershell.codeFormatting.addWhitespaceAroundPipe\" setting instead. If you've used this setting before, we have moved it for you automatically." }, "powershell.codeFormatting.addWhitespaceAroundPipe": { "type": "boolean", From 4c62c1740be8712cfe9ff8275c881acea3ba4fbd Mon Sep 17 00:00:00 2001 From: SeeminglyScience Date: Thu, 10 Mar 2022 15:41:04 -0500 Subject: [PATCH 2/2] Remove from settings.ts as well --- src/settings.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/settings.ts b/src/settings.ts index 32f5aa0d6e..c15cb0e9cd 100644 --- a/src/settings.ts +++ b/src/settings.ts @@ -84,7 +84,6 @@ export interface ISettings { // This setting is no longer used but is here to assist in cleaning up the users settings. powerShellExePath?: string; promptToUpdatePowerShell?: boolean; - promptToUpdatePackageManagement?: boolean; bundledModulesPath?: string; startAsLoginShell?: IStartAsLoginShellSettings; startAutomatically?: boolean; @@ -233,8 +232,6 @@ export function load(): ISettings { configuration.get("powerShellExePath", undefined), promptToUpdatePowerShell: configuration.get("promptToUpdatePowerShell", true), - promptToUpdatePackageManagement: - configuration.get("promptToUpdatePackageManagement", true), bundledModulesPath: "../modules", // Because the extension is always at `/out/main.js` useX86Host: