From 327e64138a840565687bcd72a04b627b25828bcc Mon Sep 17 00:00:00 2001 From: Crend King <975235+CrendKing@users.noreply.github.com> Date: Tue, 28 Sep 2021 15:05:13 -0700 Subject: [PATCH 1/3] Remove unused feature commands --- src/features/DebugSession.ts | 5 ----- src/features/ShowHelp.ts | 2 -- 2 files changed, 7 deletions(-) diff --git a/src/features/DebugSession.ts b/src/features/DebugSession.ts index a401b6bbf1..2e14822e62 100644 --- a/src/features/DebugSession.ts +++ b/src/features/DebugSession.ts @@ -25,7 +25,6 @@ export class DebugSessionFeature extends LanguageClientConsumer implements DebugConfigurationProvider, vscode.DebugAdapterDescriptorFactory { private sessionCount: number = 1; - private command: vscode.Disposable; private tempDebugProcess: PowerShellProcess; private tempSessionDetails: utils.IEditorServicesSessionDetails; @@ -51,10 +50,6 @@ export class DebugSessionFeature extends LanguageClientConsumer return new vscode.DebugAdapterInlineImplementation(debugAdapter); } - public dispose() { - this.command.dispose(); - } - public setLanguageClient(languageClient: LanguageClient) { languageClient.onNotification( StartDebuggerNotificationType, diff --git a/src/features/ShowHelp.ts b/src/features/ShowHelp.ts index ef688ec0c9..ebb6662732 100644 --- a/src/features/ShowHelp.ts +++ b/src/features/ShowHelp.ts @@ -11,7 +11,6 @@ export const ShowHelpNotificationType = export class ShowHelpFeature extends LanguageClientConsumer { private command: vscode.Disposable; - private deprecatedCommand: vscode.Disposable; constructor(private log: Logger) { super(); @@ -34,7 +33,6 @@ export class ShowHelpFeature extends LanguageClientConsumer { public dispose() { this.command.dispose(); - this.deprecatedCommand.dispose(); } } From cdfb65355aa6040b03994a27d03e166f17e90523 Mon Sep 17 00:00:00 2001 From: Crend King <975235+CrendKing@users.noreply.github.com> Date: Tue, 28 Sep 2021 16:47:08 -0700 Subject: [PATCH 2/3] Leave empty dispose() --- src/features/DebugSession.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/features/DebugSession.ts b/src/features/DebugSession.ts index 2e14822e62..79ab3af343 100644 --- a/src/features/DebugSession.ts +++ b/src/features/DebugSession.ts @@ -50,6 +50,9 @@ export class DebugSessionFeature extends LanguageClientConsumer return new vscode.DebugAdapterInlineImplementation(debugAdapter); } + public dispose() { + } + public setLanguageClient(languageClient: LanguageClient) { languageClient.onNotification( StartDebuggerNotificationType, From a1c755421a24430a3f558ab457680244b86e12fd Mon Sep 17 00:00:00 2001 From: Crend King <975235+CrendKing@users.noreply.github.com> Date: Wed, 29 Sep 2021 10:44:22 -0700 Subject: [PATCH 3/3] Temporarily disable tslint for empty block --- src/features/DebugSession.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/features/DebugSession.ts b/src/features/DebugSession.ts index 79ab3af343..bd5bf7d77d 100644 --- a/src/features/DebugSession.ts +++ b/src/features/DebugSession.ts @@ -50,6 +50,7 @@ export class DebugSessionFeature extends LanguageClientConsumer return new vscode.DebugAdapterInlineImplementation(debugAdapter); } + // tslint:disable-next-line:no-empty public dispose() { }