From 22c78f5cdae53813870685d367fc539c79ce866a Mon Sep 17 00:00:00 2001 From: Andrew Schwartzmeyer Date: Mon, 13 Sep 2021 14:49:33 -0700 Subject: [PATCH] Remove accidentally enabled commands These were apparently an experiment from when the external API was being implemented. They ended up not being used, and are not hooked up to anything. However, they were left exposed to the user, and they fail when ran (of course), so we need to delete them. --- package.json | 18 ------------------ src/features/ExternalApi.ts | 2 +- 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/package.json b/package.json index ca0b77938a..53c0b791cf 100644 --- a/package.json +++ b/package.json @@ -40,9 +40,6 @@ "onCommand:PowerShell.RestartSession", "onCommand:PowerShell.EnableISEMode", "onCommand:PowerShell.DisableISEMode", - "onCommand:PowerShell.RegisterExternalExtension", - "onCommand:PowerShell.UnregisterExternalExtension", - "onCommand:PowerShell.GetPowerShellVersionDetails", "onView:PowerShellCommands" ], "dependencies": { @@ -300,21 +297,6 @@ "light": "media/resources/light/MovePanelBottom.svg", "dark": "media/resources/dark/MovePanelBottom.svg" } - }, - { - "command": "PowerShell.RegisterExternalExtension", - "title": "Register an external extension", - "category": "PowerShell" - }, - { - "command": "PowerShell.UnregisterExternalExtension", - "title": "Unregister an external extension", - "category": "PowerShell" - }, - { - "command": "PowerShell.GetPowerShellVersionDetails", - "title": "Get details about the PowerShell version that the PowerShell extension is using", - "category": "PowerShell" } ], "menus": { diff --git a/src/features/ExternalApi.ts b/src/features/ExternalApi.ts index 100688e175..bd3d5969e7 100644 --- a/src/features/ExternalApi.ts +++ b/src/features/ExternalApi.ts @@ -125,7 +125,7 @@ export class ExternalApiFeature extends LanguageClientConsumer implements IPower // TODO: When we have more than one API version, make sure to include a check here. const extension = ExternalApiFeature.registeredExternalExtension.get(uuid); - this.log.writeDiagnostic(`Extension '${extension.id}' used command 'PowerShell.GetPowerShellVersionDetails'.`); + this.log.writeDiagnostic(`Extension '${extension.id}' called 'getPowerShellVersionDetails'`); await this.sessionManager.waitUntilStarted(); const versionDetails = this.sessionManager.getPowerShellVersionDetails();