From 211b2bc74ed6c4bc69932b6f658711b01603e44f Mon Sep 17 00:00:00 2001 From: Andrew Schwartzmeyer Date: Mon, 3 May 2021 18:14:56 -0700 Subject: [PATCH 1/2] Add semantic highlighting note to troubleshooting doc --- docs/troubleshooting.md | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/docs/troubleshooting.md b/docs/troubleshooting.md index 67c8279eb2..c6c2f76e1b 100644 --- a/docs/troubleshooting.md +++ b/docs/troubleshooting.md @@ -16,6 +16,20 @@ Instead syntax highlighting for VSCode, Atom, SublimeText and even GitHub is provided by the [Editor Syntax] repository on GitHub. Please open any [syntax highlighting issues there]. +However, with the introduction of [Semantic Highlighting] in [v2021.2.2], the +chosen colors may be different because this is applied at a layer above [Editor +Syntax]. To disable semantic highlighting and so restore the colors as they +were, set: + +```json +"[powershell]": { + "editor.semanticHighlighting.enabled": false +} +``` + +If you leave it enabled, you can customize the colors used for the various +tokens. See [#3221] for more info and to leave suggestions. + ## VSCode is not working like the ISE The PowerShell extension does not aim to perfectly recreate @@ -31,7 +45,6 @@ VSCode itself and can't be changed by the extension. The VSCode maintainers are quite reasonable though, and you can ask for new features [in their repository](https://github.com/Microsoft/vscode). - ## Known Issues in the Extension - If you are running the Preview version "PowerShell Preview" side-by-side with the stable version "PowerShell" @@ -47,7 +60,7 @@ and you can ask for new features [in their repository](https://github.com/Micros Please give the privilege management software feedback. For some, [updating to the latest version has fixed the issue](https://github.com/PowerShell/vscode-powershell/issues/2526#issuecomment-638329157). -- Intellisense is slow +- IntelliSense is slow - This is a known issue that we've been chipping away at. There doesn't seem to be any one performance drain, but we've been trying to incrementally improve performance bit-by-bit everywhere. Currently we are focusing on [this issue](https://github.com/PowerShell/PowerShellEditorServices/issues/1295). @@ -332,7 +345,9 @@ an issue on GitHub is appropriate. [open an issue on us on GitHub]: https://github.com/PowerShell/vscode-powershell/issues/new/choose [Reporting Problems]: ../README.md#reporting-problems [syntax highlighting issues there]: https://github.com/PowerShell/EditorSyntax/issues/new -[tackling an issue]:./development.md +[semantic highlighting]: https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide +[tackling an issue]: ./development.md +[v2021.2.2]: https://github.com/PowerShell/vscode-powershell/releases/tag/v2021.2.2 [VSCode issue]: https://github.com/Microsoft/vscode/issues/42356 [VSCode Settings]: https://code.visualstudio.com/docs/getstarted/settings [will break this compatibility]: https://github.com/PowerShell/vscode-powershell/issues/1310 @@ -350,3 +365,4 @@ an issue on GitHub is appropriate. [#550]: https://github.com/PowerShell/vscode-powershell/issues/550 [#647]: https://github.com/PowerShell/vscode-powershell/issues/647 [#984]: https://github.com/PowerShell/vscode-powershell/issues/984 +[#3221]: https://github.com/PowerShell/vscode-powershell/issues/3221#issuecomment-810563456 From f8ebd470a6ad8051af19ba1bc7d7fb0caf7de0ec Mon Sep 17 00:00:00 2001 From: Andrew Schwartzmeyer Date: Mon, 3 May 2021 18:17:27 -0700 Subject: [PATCH 2/2] Update contact links --- .github/ISSUE_TEMPLATE/config.yml | 12 +++--------- README.md | 2 +- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 5acadf6e2c..f3be2597dc 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,11 +1,5 @@ blank_issues_enabled: false contact_links: - - name: Editor Syntax Colorization bug report 🌈 - url: https://github.com/PowerShell/EditorSyntax/issues/new - about: Editor syntax colorization bugs are tracked in a separate GitHub repo. - - name: Script analysis or formatting bug report 🚦🖌️ - url: https://github.com/PowerShell/PSScriptAnalyzer/issues/new/choose - about: Script analysis and formatting are provided by PSScriptAnalyzer. Before submitting an issue, check to see whether the issue lies with PSScriptAnalyzer or with the VSCode PowerShell extension. - - name: General question? - url: https://aka.ms/psdiscord - about: "You can also ask general Visual Studio Code questions in the #vscode channel of the PowerShell community Discord. Slack is also available at https://aka.ms/psslack" + - name: 🙋 Ask a question + url: https://aka.ms/powershell-vscode-discord + about: "Find us in #vscode on the PowerShell Community Discord" diff --git a/README.md b/README.md index b7f7082931..59a93bd32a 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@ [![Build Status](https://dev.azure.com/powershell/vscode-powershell/_apis/build/status/PowerShell.vscode-powershell?branchName=master)](https://dev.azure.com/powershell/vscode-powershell/_build/latest?definitionId=51&branchName=master) [![Version](https://vsmarketplacebadge.apphb.com/version/ms-vscode.PowerShell.svg)](https://marketplace.visualstudio.com/items?itemName=ms-vscode.PowerShell) [![Installs](https://vsmarketplacebadge.apphb.com/installs-short/ms-vscode.PowerShell.svg)](https://marketplace.visualstudio.com/items?itemName=ms-vscode.PowerShell) -[![Discord](https://img.shields.io/discord/180528040881815552.svg?label=%23vscode&logo=discord&logoColor=white)](https://aka.ms/psdiscord) +[![Discord](https://img.shields.io/discord/180528040881815552.svg?label=%23vscode&logo=discord&logoColor=white)](https://aka.ms/powershell-vscode-discord) [![Join the chat at https://gitter.im/PowerShell/vscode-powershell](https://badges.gitter.im/PowerShell/vscode-powershell.svg)](https://gitter.im/PowerShell/vscode-powershell?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) This extension provides rich PowerShell language support for [Visual Studio Code](https://github.com/Microsoft/vscode).