From c9069fe33529f382fcd3e8bde9a01a61b62bdf93 Mon Sep 17 00:00:00 2001 From: corbob Date: Thu, 6 Dec 2018 19:48:28 -0800 Subject: [PATCH 1/4] Add icons for Command Explorer Change refrech icon to use octicons (https://octicons.github.com) --- package.json | 18 +++++++++--- resources/dark/pencil.svg | 56 ++++++++++++++++++++++++++++++++++++ resources/dark/question.svg | 56 ++++++++++++++++++++++++++++++++++++ resources/dark/refresh.svg | 1 - resources/dark/sync.svg | 56 ++++++++++++++++++++++++++++++++++++ resources/light/pencil.svg | 1 + resources/light/question.svg | 1 + resources/light/refresh.svg | 1 - resources/light/sync.svg | 55 +++++++++++++++++++++++++++++++++++ 9 files changed, 239 insertions(+), 6 deletions(-) create mode 100644 resources/dark/pencil.svg create mode 100644 resources/dark/question.svg delete mode 100644 resources/dark/refresh.svg create mode 100644 resources/dark/sync.svg create mode 100644 resources/light/pencil.svg create mode 100644 resources/light/question.svg delete mode 100644 resources/light/refresh.svg create mode 100644 resources/light/sync.svg diff --git a/package.json b/package.json index 3b447e6076..61447cebf1 100644 --- a/package.json +++ b/package.json @@ -115,14 +115,18 @@ "command": "PowerShell.RefreshCommandsExplorer", "title": "Refresh", "icon": { - "light": "resources/light/refresh.svg", - "dark": "resources/dark/refresh.svg" + "light": "resources/light/sync.svg", + "dark": "resources/dark/sync.svg" }, "category": "PowerShell" }, { "command": "PowerShell.InsertCommand", "title": "Insert Command", + "icon": { + "light": "resources/light/pencil.svg", + "dark": "resources/dark/pencil.svg" + }, "category": "PowerShell" }, { @@ -133,6 +137,10 @@ { "command": "PowerShell.ShowHelp", "title": "Get Help for Command", + "icon": { + "light": "resources/light/question.svg", + "dark": "resources/dark/question.svg" + }, "category": "PowerShell" }, { @@ -224,11 +232,13 @@ "view/item/context": [ { "command": "PowerShell.ShowHelp", - "when": "view == PowerShellCommands" + "when": "view == PowerShellCommands", + "group": "inline@1" }, { "command": "PowerShell.InsertCommand", - "when": "view == PowerShellCommands" + "when": "view == PowerShellCommands", + "group": "inline@2" } ] }, diff --git a/resources/dark/pencil.svg b/resources/dark/pencil.svg new file mode 100644 index 0000000000..e4ba2d45a8 --- /dev/null +++ b/resources/dark/pencil.svg @@ -0,0 +1,56 @@ + + + + + + image/svg+xml + + + + + + + + + diff --git a/resources/dark/question.svg b/resources/dark/question.svg new file mode 100644 index 0000000000..b803dbf391 --- /dev/null +++ b/resources/dark/question.svg @@ -0,0 +1,56 @@ + + + + + + image/svg+xml + + + + + + + + + diff --git a/resources/dark/refresh.svg b/resources/dark/refresh.svg deleted file mode 100644 index d79fdaa4e8..0000000000 --- a/resources/dark/refresh.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/resources/dark/sync.svg b/resources/dark/sync.svg new file mode 100644 index 0000000000..f3d5a1bc00 --- /dev/null +++ b/resources/dark/sync.svg @@ -0,0 +1,56 @@ + + + + + + image/svg+xml + + + + + + + + + diff --git a/resources/light/pencil.svg b/resources/light/pencil.svg new file mode 100644 index 0000000000..8702f4dcec --- /dev/null +++ b/resources/light/pencil.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/resources/light/question.svg b/resources/light/question.svg new file mode 100644 index 0000000000..a6fc75310c --- /dev/null +++ b/resources/light/question.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/resources/light/refresh.svg b/resources/light/refresh.svg deleted file mode 100644 index e034574819..0000000000 --- a/resources/light/refresh.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/resources/light/sync.svg b/resources/light/sync.svg new file mode 100644 index 0000000000..411f549b58 --- /dev/null +++ b/resources/light/sync.svg @@ -0,0 +1,55 @@ + + + + + + image/svg+xml + + + + + + + + From b1a5bdd0f337df602577ef931102ab4b710dbc93 Mon Sep 17 00:00:00 2001 From: corbob Date: Thu, 6 Dec 2018 20:43:41 -0800 Subject: [PATCH 2/4] Update Command Palette Reword Refresh to specify what it's Refreshing. Remove Insert from Command Palette. --- package.json | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 61447cebf1..acfcb8b797 100644 --- a/package.json +++ b/package.json @@ -113,7 +113,7 @@ }, { "command": "PowerShell.RefreshCommandsExplorer", - "title": "Refresh", + "title": "Refresh Command Explorer", "icon": { "light": "resources/light/sync.svg", "dark": "resources/dark/sync.svg" @@ -210,6 +210,12 @@ } ], "menus": { + "commandPalette": [ + { + "command": "PowerShell.InsertCommand", + "when": "false" + } + ], "editor/context": [ { "when": "editorLangId == powershell", From 0c16a789078c746954fde7ad2532e89575b8c2e2 Mon Sep 17 00:00:00 2001 From: corbob Date: Fri, 7 Dec 2018 20:08:29 -0800 Subject: [PATCH 3/4] Add Configuration to toggle Command Explorer visibility. --- package.json | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index acfcb8b797..58298d8a37 100644 --- a/package.json +++ b/package.json @@ -72,7 +72,8 @@ "PowerShellCommandExplorer": [ { "id": "PowerShellCommands", - "name": "PowerShell Commands" + "name": "PowerShell Commands", + "when": "config.powershell.sideBar.CommandExplorerVisibility" } ] }, @@ -214,6 +215,10 @@ { "command": "PowerShell.InsertCommand", "when": "false" + }, + { + "command": "PowerShell.RefreshCommandsExplorer", + "when": "config.powershell.sideBar.CommandExplorerVisibility" } ], "editor/context": [ @@ -472,6 +477,11 @@ "type": "object", "title": "PowerShell Configuration", "properties": { + "powershell.sideBar.CommandExplorerVisibility": { + "type": "boolean", + "default":true, + "description": "Specifies the visibility of the Command Explorer in the PowerShell sidebar." + }, "powershell.powerShellExePath": { "type": "string", "default": "", From 3efc73e7270f2615d5744e9887c0da3bfb48fa1a Mon Sep 17 00:00:00 2001 From: corbob Date: Thu, 20 Dec 2018 08:56:37 -0800 Subject: [PATCH 4/4] sidebar -> Side Bar Be consistent with UI --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 58298d8a37..978bf09aa2 100644 --- a/package.json +++ b/package.json @@ -480,7 +480,7 @@ "powershell.sideBar.CommandExplorerVisibility": { "type": "boolean", "default":true, - "description": "Specifies the visibility of the Command Explorer in the PowerShell sidebar." + "description": "Specifies the visibility of the Command Explorer in the PowerShell Side Bar." }, "powershell.powerShellExePath": { "type": "string",