-
Notifications
You must be signed in to change notification settings - Fork 511
Add a "Report a problem on GitHub" command that automates filing a bug on GitHub #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
FWIW now that I'm a bit more The problem with relying on PSES is that sometimes the issue is that PSES never started. :-) |
Yep, it's true that there are cases where PSES won't be started, but my approach would be to provide a command in the PSES module that can be run in plain old powershell.exe without requiring an actual session to be active. The problem with using the Node.js archiver module is that we'd have to get OSS appoval to use it, so it's probably better to continue using what we have available in PowerShell for zipping the log files. |
Ah, so no need to wire up a PSES request to trigger and get data back to the extension. We would just spawn PowerShell with the PSES command, right? |
Yep, exactly! We would run whichever PowerShell the user had configured just long enough to run that command and scrape its output. |
Let's give @PowerSchill a shot at implementing this so that he can get comfortable contributing features :) |
Making progress... Is it acceptable to exclude the builtin extensions from extension list or do you feel it is useful to leave them included? |
Let's exclude for now, I think it's only useful to know the non-standard extensions the user has. Awesome that you're making progress! |
I have created the code for creating the bug report. When selected it will collect the information below and open a new issue in the GitHub project. There is still some cleanup involved as well as handling log files. Is there any adjustments anyone see needed?
Issue DescriptionI am experiencing a problem with... Attached LogsFollow the instructions in the README about capturing and sending logs. Environment InformationVisual Studio Code
PowerShell Information
Visual Studio Code Extensions
|
Any chance we can automatically attach the logs via a zip file? |
I will look into it but I don't know that it is possible to attach a file to the issue via URL. If that is in fact the case then I might just have to create the zip and then instruct the user to attach it to the ticket manually. |
At one point I thought @daviwil said there was a way to upload attachments to GitHub but I don't see it in the v3 REST API. Dude, that is quite the list of extensions you have installed. :-) I wonder if we should put the VSCode extensions list in a collapsible section? E.g.: Visual Studio Code Extension (click to expand)...Not all browsers support this HTML tag (Edge doesn't) but FireFox does and I suspect Chrome does as well. |
I added the code to collapse the extension listing. |
Good news on the Edge front. Just installed today's Windows 10 Insider build and Edge displays the "details" section as collapsed. |
In logging.ts there are comments about it not being easy to open the logs in the operating system file browser. Is that still the case? |
Yeah, there isn't an API to open the native file browser for each platform. We could try to do it manually but it'd require having unique code for Windows, macOS, and Linux. I could have sworn I had seen an API for attaching a file to an issue, but looks like it never existed! |
@daviwil In relation to the above conversation about compression can we use the Node zlib library without legal issues? Also would that be a function better at home with the Logger class? |
We need a command that will make it super easy for users to file new issues on GitHub so that they don't have to manually gather details on versions and environment information. I imagine this will be a combination of TypeScript and PowerShell code. @rkeithhill has started some of the PowerShell side code in PowerShell Editor Services.
You can see how VS Code generates their issue data here:
https://github.com/Microsoft/vscode/blob/f1f3f60e300abae4055a2a9fe3c40c63be5a8e82/src/vs/workbench/electron-browser/actions.ts#L704
@PowerSchill has expressed an interest in working on this :)
The text was updated successfully, but these errors were encountered: