Skip to content

Folding HereStrings #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mpearon opened this issue Apr 29, 2017 · 4 comments
Closed

Folding HereStrings #704

mpearon opened this issue Apr 29, 2017 · 4 comments

Comments

@mpearon
Copy link

mpearon commented Apr 29, 2017

System Details

  • Operating system name and version: Windows 10 v1607 Build 14939.1066
  • VS Code version: 1.11.2
  • PowerShell extension version: 0.12.2
  • Output from $PSVersionTable:

PSVersion 5.1.14393.1066
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.14393.1066
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1

Issue Description

I'm sure this has been mentioned before, but I can't seem to find any open tickets.
Any time HereStrings are used throughout my scripts, 1) they do not fold and 2) they break folding for parent elements (Functions or Regions in my case).

Here is a gif of the behavior, and I've included the exact code for you to play with below.
brokenfolding

Function foldingDemo{
    #Region > Proper Fold >
        $testString = 'This region folds'
    #Region < Proper Fold <

    #Region > Broken Fold >
        $testHereString = @'
- The HereString does not offer folding
- This region does not fold properly
- The folding for the function breaks at this point
'@
    #Region < Broken Fold <
}
@rkeithhill
Copy link
Contributor

Duplicate of #525. I encourage you to complain to the VSCode team via this issue: microsoft/vscode#3422

@mpearon
Copy link
Author

mpearon commented Apr 29, 2017

Thank you @rkeithhill. I've added my name and demo to the list!

@rkeithhill
Copy link
Contributor

@mpearon Thanks! Every bit of feedback to the VSCode team helps (I hope). :-)

@mpearon
Copy link
Author

mpearon commented Jul 12, 2018

I just want to make note that the language-aware folding was implemented in PowerShell 1.8.0/1!
Great job, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants