Skip to content

v2022.11.1-preview butchers terminal prompt using WinPS 5.1 #4279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
Hetshu opened this issue Nov 22, 2022 · 6 comments · Fixed by PowerShell/PowerShellEditorServices#1961
Closed
6 tasks done
Assignees
Labels
Area-Extension Terminal Bug: PowerShell 5.1 Bugs when using PowerShell 5.1. Bug: Pre-release Bugs reproducing only in the pre-release extension. Issue-Bug A bug to squash.

Comments

@Hetshu
Copy link

Hetshu commented Nov 22, 2022

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all open and closed issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
  • If this is a security issue, I have read the security issue reporting guidance.

Summary

Powershell Extension terminal prompt shows escape characters:

image

PowerShell Version

Name                           Value
----                           -----
PSVersion                      5.1.19041.1682
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.1682
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Visual Studio Code Version

1.73.1
6261075646f055b99068d3688932416f2346dd3b
x64

Extension Version

Steps to Reproduce

Open a powershell script to activate the extension, switch to WinPS 5.1 and watch the prompt

Visuals

No response

Logs

No response

@Hetshu Hetshu added the Issue-Bug A bug to squash. label Nov 22, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Nov 22, 2022
@PrzemyslawKlys
Copy link
Contributor

Can confirm:

image

@DarkLite1
Copy link

Confirmed:
image

@andyleejordan andyleejordan changed the title v2022.11.1 butchers terminal prompt using WinPS 5.1 v2022.11.1-preview butchers terminal prompt using WinPS 5.1 Nov 22, 2022
@andyleejordan andyleejordan added Bug: PowerShell 5.1 Bugs when using PowerShell 5.1. Bug: Pre-release Bugs reproducing only in the pre-release extension. labels Nov 22, 2022
@andyleejordan
Copy link
Member

Is shell integration supposed to work in PowerShell 5.1 in the first place? If not, I'll have to put a guard around it.

@andyleejordan
Copy link
Member

Note: On Windows, you'll need PowerShell 7 (pwsh) for shell integration support.

Ahh.

@MrFly72
Copy link

MrFly72 commented Nov 23, 2022

Can confirm, too.
I have to go back to Production release, as I need to change between 5.1 and 7.x quite frequently as I have some old PSSnappin-Sh*t....

@andyleejordan
Copy link
Member

@MrFly72 we've got a fix at the ready, and we got it upstream too! Sorry about the temporary inconvenience, but won't be a problem next preview!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extension Terminal Bug: PowerShell 5.1 Bugs when using PowerShell 5.1. Bug: Pre-release Bugs reproducing only in the pre-release extension. Issue-Bug A bug to squash.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants