Skip to content

Ctrl+Alt+ keybindings should not be used by default under Windows. #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dustinmoris opened this issue Jan 12, 2017 · 3 comments
Closed
Labels
Issue-Bug A bug to squash.
Milestone

Comments

@dustinmoris
Copy link

The PowerShell keybindings offend the convention that Ctrl+Alt+ should not be used under Windows by default:

image

This is the warning from the developer tools in VS Code under Windows.

The exact offender is this one:

{ "key": "ctrl+alt+e",            "command": "PowerShell.ExpandAlias",
                                     "when": "editorTextFocus && editorLangId == 'powershell'" }
@daviwil
Copy link
Contributor

daviwil commented Jan 12, 2017

It's more of a warning than an error so it can be safely ignored. That said, we haven't come up with a better unused key combination for this command, any suggestions?

@dustinmoris
Copy link
Author

dustinmoris commented Jan 25, 2017

Hi, I just checked and Shift+Alt+E is a free keybinding and Shift is just above Ctrl, so the muscle memory in our hand should quickly get used to Shift+Alt+E after a change :)

I wouldn't worry too much about the default key bindings anyway, because from my experience devs quickly change the ones they need anyway. As long as the default doesn't cause a lot of warnings in the dev tools output it should be fine.

@daviwil
Copy link
Contributor

daviwil commented Jan 25, 2017

Ahhh great idea! I'll change it to that.

@daviwil daviwil added the Issue-Bug A bug to squash. label Jan 25, 2017
@daviwil daviwil added this to the 0.9.1 milestone Jan 25, 2017
@daviwil daviwil modified the milestones: 0.9.1, 0.10.0 Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

2 participants