Wrong indent for pipelines

[aelij]

Prerequisites

• I have written a descriptive issue title.
• I have searched all open and closed issues to ensure it has not already been reported.
• I have read the troubleshooting guide.
• I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
• I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
• If this is a security issue, I have read the security issue reporting guidance.

Summary

PowerShell allows line breaks in pipelines without a backtick. I would expect the editor to indent it as if the backtick was present.

PowerShell Version

Name                           Value
----                           -----
PSVersion                      7.2.7
PSEdition                      Core
GitCommitId                    7.2.7
OS                             Microsoft Windows 10.0.22621
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visual Studio Code Version

1.73.0
8fa188b2b301d36553cbc9ce1b0a146ccb93351f

Extension Version

[email protected]

Steps to Reproduce

Expected:

Get-ChildItem |
  Select-Object Name

Get-ChildItem | `
  Select-Object Name

Actual:

Get-ChildItem |
Select-Object Name

Get-ChildItem | `
  Select-Object Name

Visuals

No response

Logs

No response

[andyleejordan]

Formatting is done via PSScriptAnalyzer, can you test if this repros independently via PSSA without the editor? That is, run the repro through Invoke-Formatter and see what happens 😄

[aelij]

Invoke-Formatter (version 1.21.0) works as expected

> Invoke-Formatter -ScriptDefinition 'Get-ChildItem |
>> Select-Object Name'
Get-ChildItem |
    Select-Object Name

[RansomVO]

I have a similar issue which started after I did an update last week. In my case formatting is ignoring the Code Formatting settings:

• New Line After Close Brace
• New Line After Open Brace
• Open Brace On Same Line

And it reformats my scripts completely.

[aelij]

@RansomVO I suggest you open a separate issue for this

[RansomVO]

@aelij Opened #4283

[andyleejordan]

@aelij What do you have your powershell.codeFormatting.preset set to? If it's anything other than Custom (the default) then my understanding is that it will override the other settings.

[andyleejordan]

@aelij oh, re-reading your issue, I think for your expected scenario you just need to configure powershell.codeFormatting.pipelineIndentationStyle. The default (and I don't know why) is NoIndentation but if you set it to IncreaseIndentationForFirstPipeline it will (mostly) do what you want. In testing, though, I discovered that the second block of code will double-indent, and I'm not sure why, but probably because scripts aren't really expected to use | <backtick> at the end of a line since both | and <backtick> are line-continuations in PowerShell scripts.

[ghost]

This issue has been marked as answered and has not had any activity in a day. It has been automatically closed for housekeeping purposes.

[aelij]

@andschwa Can we change the default? It doesn't make sense IMO

[andyleejordan]

@aelij I agree, and so I opened an RFC here, please do share your comment: #4296