Skip to content

Additional PowerShell executables: Warning if versionName cannot be resolved #4129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
sofa1780 opened this issue Aug 12, 2022 · 0 comments · Fixed by #4295
Closed
2 tasks done

Additional PowerShell executables: Warning if versionName cannot be resolved #4129

sofa1780 opened this issue Aug 12, 2022 · 0 comments · Fixed by #4295
Assignees
Labels
Area-Configuration Issue-Enhancement A feature request (enhancement).

Comments

@sofa1780
Copy link

sofa1780 commented Aug 12, 2022

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.

Summary

If the PowerShell setting for assigning additional execution paths (powershell.powerShellAdditionalExePaths) is used with an invalid versionName parameter shown within the snippet down below no warning appears.

This can lead to an unnoticed use of a different PowerShell version than defined seemingly within the settings since the value "Windows PowerShell 5.1 (x86)" for the parameter VersionName is not valid.
Instead, the correct value should be "Windows PowerShell (x86)".

"powershell.powerShellAdditionalExePaths": {
    "Windows PowerShell 5.1 (x64)": "%SystemRoot%\\syswow64\\WindowsPowerShell\\v1.0\\powershell.exe",
    "Windows PowerShell 5.1 (x86)": "%SystemRoot%\\system32\\WindowsPowerShell\\v1.0\\powershell.exe",
},
"powershell.powerShellDefaultVersion": "Windows PowerShell 5.1 (x86)",

Proposed Design

This manner could be accomplished by either informing the user or accepting the user-defined value for parameter versionName.

@sofa1780 sofa1780 added the Issue-Enhancement A feature request (enhancement). label Aug 12, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Aug 12, 2022
@SydneyhSmith SydneyhSmith added Up for Grabs Will shepherd PRs. Area-Configuration and removed Needs: Triage Maintainer attention needed! labels Aug 16, 2022
@andyleejordan andyleejordan removed the Up for Grabs Will shepherd PRs. label Nov 30, 2022
@andyleejordan andyleejordan self-assigned this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Configuration Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants