Skip to content

Add back "PowerShell" text indicator when running a "Editor Command" #3954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
ghost opened this issue May 6, 2022 · 9 comments · Fixed by #4187
Closed
2 tasks done

Add back "PowerShell" text indicator when running a "Editor Command" #3954

ghost opened this issue May 6, 2022 · 9 comments · Fixed by #4187
Assignees
Labels
Area-UI Issue-Enhancement A feature request (enhancement).

Comments

@ghost
Copy link

ghost commented May 6, 2022

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.

Summary

In previous versions of the PowerShell extension, when I ran an Editor Command associated with PS1 file, it would show the text "PowerShell" in the bottom left corner. When the command finished running, the PowerShell text would go away. This was a nice indicator letting me when the command had finished, and I knew I could go look for the results. In my case, my command (by use of Microsoft.VSCode_profile.ps1 with the script block registered as an Editor Command) signs the script, compiles the PS1 into an EXE format (for both .NET 4.8 and .NET 6.x formats), and then signs the executables. This whole process takes a bit of time...long enough that the "PowerShell" text indicator "going away" really helped let me know when it was done. With the current version, I have to wait "until I think it should be done" to check it.

image

As of version v2022.5.0, this feature no longer exists.

Proposed Design

Please add the "PowerShell" text (or some other indicator) to the bottom (or other obvious location) of VSCode when an Editor Command is running and then hide it when the command finishes. For an example of this, check out any previous version of the extension prior to v2022.5.0. Hopefully this is an easy add, since it already worked in previous versions.

@ghost ghost added Issue-Enhancement A feature request (enhancement). Needs: Triage Maintainer attention needed! labels May 6, 2022
@SydneyhSmith
Copy link
Collaborator

Thanks @NJK-HOME we will keep this issue open for investigation

@shangles
Copy link

Thanks for posting about this before I could. The removal of any kind of visual cue that PowerShell is running a command has been frustrating for me.

@shangles
Copy link

There's an animated spinning icon in the lower-right that appears when PowerShell is "starting" It makes sense to have the same area animate progress when a script is running.

@shangles
Copy link

Just curious. I see "2 tasks done" at the top of this issue. I'm a github newbie and can't see what tasks are completed... and which ones are remaining to be completed. Does this mean there's progress on this enhancement for a future update?

@panekj
Copy link

panekj commented May 28, 2022

It refers to this
image

If there will be an ongoing fix or something else, it will most likely show up as update between comments

@shangles
Copy link

shangles commented Aug 6, 2022

Any update on when we might see this feature implemented?

@shangles
Copy link

Monthly bump

@andyleejordan
Copy link
Member

Working on it, I've at least found the ends of the wires that need to be spliced back together (if that makes sense).

@shangles
Copy link

I love this update. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants