Skip to content

F8 during debug session forces continuation #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
PrzemyslawKlys opened this issue Apr 30, 2022 · 1 comment · Fixed by PowerShell/PowerShellEditorServices#1784
Closed
6 tasks done
Labels

Comments

@PrzemyslawKlys
Copy link
Contributor

PrzemyslawKlys commented Apr 30, 2022

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
  • If this is a security issue, I have read the security issue reporting guidance.

Summary

If you use a breakpoint, run code with F5 and wait for it to hit a breakpoint, and then use F8 to run code within Visual Studio Code - debugging will continue instead of doing nothing. I am not sure when it went bonkers, but I just noticed it now. It used to work fine.

My suspect is related to:

I'm curious, does this problem go away if we write a line after invoking readline if the task has been canceled?
See this part of the change (which was what allowed us to "re-use" the existing prompt for F5 and F8 input):

But this is just a guess based on F8 being included in the text :)

Edit: After speaking to @SeeminglyScience it seems to be related to:

PowerShell Version

Name                           Value
----                           -----
PSVersion                      5.1.22000.652
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22000.652
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Visual Studio Code Version

1.66.2
dfd34e8260c270da74b5c2d86d61aee4b6d56977
x64

Extension Version

Steps to Reproduce

  1. Open code
  2. Set breakpoint
  3. Run F5
  4. Wait for breakpoint to be hit
  5. Once hit, press F8 with selected text or without

Visuals

F8 continue

Logs

No response

@PrzemyslawKlys PrzemyslawKlys added the Issue-Bug A bug to squash. label Apr 30, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Apr 30, 2022
@PrzemyslawKlys PrzemyslawKlys changed the title F8 during debug session breaks debugging F8 during debug session forces continuation May 1, 2022
@SeeminglyScience
Copy link
Collaborator

Edit: After speaking to @SeeminglyScience it seems to be related to:

Note: turned out to be unrelated and was just a logic error on my part at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants