Skip to content

Go To Definition/Find All References with scope modifier #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LethiferousMoose opened this issue Dec 17, 2016 · 2 comments
Closed

Go To Definition/Find All References with scope modifier #393

LethiferousMoose opened this issue Dec 17, 2016 · 2 comments
Labels
Issue-Enhancement A feature request (enhancement).

Comments

@LethiferousMoose
Copy link

Please fill in these details so that we can help you!

System Details

  • Operating system name and version:
  • VS Code version: 1.8.0
  • PowerShell extension version: 0.7.2
  • Output from $PSVersionTable:
    PSVersion 5.0.10240.17146
    WSManStackVersion 3.0
    SerializationVersion 1.1.0.1
    CLRVersion 4.0.30319.42000
    BuildVersion 10.0.10011.16384
    PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
    PSRemotingProtocolVersion 2.3

Issue Description

This is in the same boat as issue #379 I logged. If I use a scope modifier (like $Script:) in front of a variable Go To Definition cannot find the definition. Similarly Find All References will only find all references that use the modifier and not the initial declaration at the script level. This one could be tricky to implement because variables set in a function with the same name as a script level variable are created at the Local scope.

@daviwil daviwil added the Issue-Enhancement A feature request (enhancement). label Dec 17, 2016
@daviwil
Copy link
Contributor

daviwil commented Dec 17, 2016

Yep, we haven't done the necessary work to make all of our language featues scope-aware. This is being tracked here: PowerShell/PowerShellEditorServices#16. We'll be starting on this work within the next couple of months.

@TylerLeonhardt
Copy link
Member

Closing this as a dupe of PowerShell/PowerShellEditorServices#16 but we still need to make things scope aware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

3 participants