Skip to content

Some _other_ way to get the PowerShell Integrated Console when I set showOnStartup to false #3918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
TylerLeonhardt opened this issue Apr 12, 2022 · 5 comments · Fixed by #4096
Closed
2 tasks done
Assignees

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Apr 12, 2022

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.

Summary

I don't like the integrated terminal popping up in the beginning. I understand why it does that, but for me, I set showOnStartup to false because I want it to be in the background. However, when I do want it, I only have one option: the command palette: Show Integrated Console or probably another one is starting a debug session.

It would be nice if there was another way to get at this.

Proposed Design

Couple options... still thinking out loud though:


Could the PowerShell extension contribute a Terminal Profile so that it shows up in this list:
image

Then if you click on it, it will show up? The only thing I'm not so sure about is how does this work if you choose that profile multiple times (since there currently can only be 1 (ish) Integrated Console)? (an interesting thought @Tyriar @meganrogge)


Maybe there could be another Language Status entry for showing the Integrated Console?


Perhaps a button in the top right that shows the Integrated Console (when it's hidden)?
image

@TylerLeonhardt TylerLeonhardt added the Issue-Enhancement A feature request (enhancement). label Apr 12, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Apr 12, 2022
@meganrogge
Copy link

You called out a concern I'd have with putting it in the dropdown - that the integrated console can't get created multiple times whereas the other profiles can be.

Once it's been created, we could handle this by either removing the item from the dropdown or disabling it.

That would require new API on ExtensionTerminalOptions, for example:

singleton?: boolean;

@TylerLeonhardt
Copy link
Member Author

Of course #2418 would make this issue invalid. It's something I always wanted to experiment with... essentially having multiple Integrated Consoles (and thus multiple langugage servers) and then the most recent active PSIC would "take over" as the active language server. This is how ISE does it.

but that's a "run" where we should probably crawl and walk first :)

@andyleejordan
Copy link
Member

Yeah for real, this is annoying (just set this setting myself and I'm like...where on earth is the console).

@JustinGrote
Copy link
Collaborator

I'm pretty sure running Restart Integrated Terminal command makes it pop up again, not really intuitive but an alias command to run the same process could be made that says "Start Integrated Terminal"

@Tyriar
Copy link
Contributor

Tyriar commented May 2, 2022

I don't think the singleton idea would be generally useful to other extensions so I'm not a fan.

@andyleejordan andyleejordan linked a pull request Jul 28, 2022 that will close this issue
@andyleejordan andyleejordan self-assigned this Jul 28, 2022
@andyleejordan andyleejordan moved this to In Progress in American Pharoah Jul 28, 2022
Repository owner moved this from In Progress to Done in American Pharoah Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants