Skip to content

Current Preview does not have an option anymore to switch from Core-->Desktop and back #3874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
MrFly72 opened this issue Mar 14, 2022 · 7 comments · Fixed by #3877
Closed
5 tasks done
Assignees
Labels
Area-UI Issue-Bug A bug to squash.

Comments

@MrFly72
Copy link

MrFly72 commented Mar 14, 2022

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.

Summary

Since the latest preview the option bottom right to change to the "other" version of powershell is missing.
Going back to production, the switch is back again

PowerShell Version

PS 30.99 ms | C:\> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.2.1
PSEdition                      Core
GitCommitId                    7.2.1
OS                             Microsoft Windows 10.0.19043
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visual Studio Code Version

PS 512.5 ms | C:\> code --version
1.65.2
c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1
x64

Extension Version

PS 452.61 ms | C:\> code --list-extensions --show-versions | Select-String powershell

[email protected]
[email protected]
[email protected]

Steps to Reproduce

Install preview.
Try switching from PS 7.2.1 to Desktop 5.1.

On older versions, clicking on 7.2 (in the picture) brings the change option

Visuals

image

before:
image

C

Logs

No response

@MrFly72 MrFly72 added the Issue-Bug A bug to squash. label Mar 14, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Mar 14, 2022
@MrFly72
Copy link
Author

MrFly72 commented Mar 14, 2022

Puh. Never mind. In the moment posting this, I hoovered over some of the buttons and wondered when this came up:
image

Sorry, but did not find this change anywhere in the docs ???

@JustinGrote
Copy link
Collaborator

@MrFly72 it was this PR, it will be in the docs for the stable release
#3869

@andyleejordan
Copy link
Member

Sorry @MrFly72! We're working on a compiled release notes (and doc updates) as we inch toward the finish line to get these preview released to stable, thanks for testing! We really appreciate it.

@MrFly72
Copy link
Author

MrFly72 commented Mar 14, 2022

No problem at all. its in my eyes not really comfortable if you switch Desktop<--> Core, as it would be one click more. I pinned it right away to get the second click away.
Additionally to that, what I dont like is, to figure which version I use, I now have to hoover and can not see with one view.
I am constantly switching between editions, as I use 7.x a lot for big datasets, as it is a lot faster then 5.1 in sort, group, select on big data arrays (usually 150.000 - 1.000.000 datasets).
but i need 5.1 as some of the module i have to use for products is not 7.x ready.
in my eyes dual work (5.1 + 7.x) in VSCode should be massively improved to not switch, but have both versions running and can easily decide which one to use. Switching is very time consuming.

@JustinGrote
Copy link
Collaborator

JustinGrote commented Mar 14, 2022

@MrFly72 if you click the "pin" command then you will have similar behavior to the "old" method. Also if you are not aware you can import 5.1 modules into 7 via -UseWindowsPowershell parameter of import-module
https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_windows_powershell_compatibility?view=powershell-7.2

@MrFly72
Copy link
Author

MrFly72 commented Mar 15, 2022

@JustinGrote I did Pin it already. It is not full the same behaviour. As stated above it does not show the release choosen anymore, like it did before:
image
Now I have to hoover over the little icon to see, what I am running at the moment:
image

For the modules. I do know, that I can import modules from 5.1 in 7.x.
BUT there are modules as stated which cannot be imported as the developers did not make the modules compatible with 7.x.
eg. Citrix Virtual Apps an Desktops, which is basically a wrapper to Add-PSSnapin, I know this is nonsense, but nevertheless I have to use it in my everyday work. My own modules are always 7.x aware, which is also not easy, as there are a couple of things where you have to script workarounds, eg:

  • Missing Test-NetConnectiion --> Have to program around it to use test-connection in 7.x to make the code univeral and linux compatible
  • Escapehandling in convertto-json, which is missing in 7.x and 7.x invoke-restmethods sometimes needs it for umlauts, but 5.1 invoke-restmethod seems to do it by itself.
    Dont take me wrong. I love VSCode and PS-Extension and working 100 % with it, and scripting about 50% of my day, handling huge data amounts and a lot of parallel working in a 250.000 User / 1000 Server/ 150.000 Clients environment, with Azure and AWS Cloud + Citrix Cloud. I just want to give valuable feedback from "the field".
    I would love to switch less between 5.1 and 7.x but as said the OnPrem Citrix Modules dont allow me to and they did not change it until today.

@andyleejordan
Copy link
Member

@MrFly72 We can put the version back next to the icon, I think that totally makes sense. I'll re-open this and get it into the next preview.

@andyleejordan andyleejordan reopened this Mar 15, 2022
@andyleejordan andyleejordan moved this to Todo in Sea Biscuit Mar 15, 2022
@andyleejordan andyleejordan added Area-UI and removed Needs: Triage Maintainer attention needed! labels Mar 15, 2022
@andyleejordan andyleejordan self-assigned this Mar 15, 2022
@andyleejordan andyleejordan moved this from Todo to In Progress in Sea Biscuit Mar 15, 2022
Repository owner moved this from In Progress to Done in Sea Biscuit Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Bug A bug to squash.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants