Skip to content

The menu 'Go to Definition' does not support 'Module-Qualified Cmdlet Names' syntax #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
LaurentDardenne opened this issue Feb 19, 2022 · 3 comments
Closed
5 tasks done
Labels
Area-Script Analysis Issue-Bug A bug to squash. Resolution-Fixed Will close automatically.

Comments

@LaurentDardenne
Copy link

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.

Summary

Once added a module name to a function name, 'the menu' considers this syntax as a full function name.

see: #928

PowerShell Version

Name                           Value
----                           -----
PSVersion                      5.1.19041.1320
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0, 5.0, 5.1.19041.1320}
BuildVersion                   10.0.19041.1320
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Visual Studio Code Version

1.64.2
f80445acd5a3dadef24aa209168452a3d97cc326
x64

Extension Version

Steps to Reproduce

Use the 'Module-Qualified Cmdlet Names' syntax into a script.

Visuals

Before

inside the module
image

inside a script
image

After

inside a script
image

inside the module
image

Logs

No response

@LaurentDardenne LaurentDardenne added the Issue-Bug A bug to squash. label Feb 19, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Feb 19, 2022
@SydneyhSmith
Copy link
Collaborator

SydneyhSmith commented Feb 22, 2022

Thanks @LaurentDardenne for opening this issue and for providing the repro steps! We dont have scheduled time for this fix at the moment but I will mark it as up for grabs

@SydneyhSmith SydneyhSmith added Area-Script Analysis and removed Needs: Triage Maintainer attention needed! labels Feb 22, 2022
@SydneyhSmith SydneyhSmith added this to the Consider-vNext milestone Feb 22, 2022
@SydneyhSmith SydneyhSmith added the Up for Grabs Will shepherd PRs. label Feb 22, 2022
@SydneyhSmith SydneyhSmith moved this to Wishlist in American Pharoah May 9, 2022
@SydneyhSmith SydneyhSmith removed this from the Consider-vNext milestone Aug 9, 2022
@andyleejordan
Copy link
Member

This is mostly fixed. That is, the problem where the command name's when qualified with a module name treated the whole string as the command name has been fixed by stripping the module name when building the reference tables. However, we still have a separate "problem" where we can't jump to definition (or find references) in modules that are only imported via the import statement in a piece of code; the actual definition/references must be in script files within the workspace.

@andyleejordan andyleejordan added Resolution-Fixed Will close automatically. and removed Up for Grabs Will shepherd PRs. labels Feb 22, 2023
@ghost ghost closed this as completed Feb 22, 2023
@ghost
Copy link

ghost commented Feb 22, 2023

This issue has been marked as fixed. It has been automatically closed for housekeeping purposes.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Script Analysis Issue-Bug A bug to squash. Resolution-Fixed Will close automatically.
Projects
None yet
Development

No branches or pull requests

3 participants