Get-Credential throws exception instead of prompting for input in PowerShell 5.1

[csandfeld]

Prerequisites

• I have written a descriptive issue title.
• I have searched all issues to ensure it has not already been reported.
• I have read the troubleshooting guide.
• I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
• I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.

Summary

When using preview v2022.2.0 with Windows PowerShell 5.1, this exception is throw in the integrated console when running Get-Credential.

PS C:\> Get-Credential
Get-Credential : Cannot process command because of one or more missing mandatory parameters: Credential.
At line:1 char:1
+ Get-Credential
+ ~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [Get-Credential], ParameterBindingException
    + FullyQualifiedErrorId : MissingMandatoryParameter,Microsoft.PowerShell.Commands.GetCredentialCommand
 
PS C:\> 

This is not the case when using PowerShell Extension v2021.12.0, or when using PowerShell 7.2.1 instead of Windows PowerShell.

PowerShell Version

PS C:\> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.1320
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.1320
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Visual Studio Code Version

PS C:\> code --version
1.64.1
d6ee99e4c045a6716e5c653d7da8e9ae6f5a8b03
x64
PS C:\>

Extension Version

PS C:\> code --list-extensions --show-versions                           
[email protected]
[email protected]
PS C:\>

Steps to Reproduce

• Open Visual Studio Code
• Install PowerShell Preview extension
• Configure integrated console to use Windows PowerShell x64
• Run Get-Credential (either directly in console, or by pressing F8 - makes no difference)

Visuals

No response

Logs

No response

[JustinGrote]

I can't reproduce:

[csandfeld]

Try just Get-Credential (without the -Message 'ok' param)

[csandfeld]

Same test as above with v2021.12.0

[csandfeld]

Is further repro info needed?

[JustinGrote]

@csandfeld so I can repro it as you state, not sure why Get-Credential would have its parameters parsed differently in the PSIC than in regular console. @andschwa @SeeminglyScience any ideas?

[JustinGrote]

I noticed that the Credential parameter is flagged mandatory in 5.1, but it doesn't follow the usual behavior of showing the mandatory parameter error, instead it hooks into the WPF GUI to prompt for the mandatory value, I'm guessing our Host doesn't support that, and it fails. 7.1 doesn't do this because it always uses a text-based prompt rather than trying a GUI prompt.

[JustinGrote]

@andschwa It is because our PS Host is advertising NonInteractive mode. Read-Host has same problem. Is interactive mode possible with the new pipeline engine?

PSIC> read-host 'test'
read-host : Windows PowerShell is in NonInteractive mode. Read and Prompt 
functionality is not available.
At line:1 char:1
+ read-host 'test'
+ ~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [Read-Host], PSInvalidOperatio 
   nException
    + FullyQualifiedErrorId : InvalidOperation,Microsoft.PowerShell.Commands.ReadH 
   ostCommand

[andyleejordan]

Oh, good find! I can dig into this.

[andyleejordan]

So yes, we've been passing -NonInteractive to PowerShell at startup. This sets a flag at a really low level within PowerShell itself, which is a bit frightful, but in my basic testing just now it seems like nothing breaks when we remove the flag. Let's give it a try?

[andyleejordan]

Ok so apparently we need -NonInteractive to prevent Windows PowerShell from loading its own bundled PSReadLine (this is pending verification, it may no longer be true in PSESv3) and so the previous workaround was that we'd implemented our own Get-Credential hence why this is now showing up. Thanks @SeeminglyScience!

[andyleejordan]

Looks like we've got a fix!

[andyleejordan]

The fix for this is out in PowerShell Preview v2022.2.2!

[csandfeld]

That's great news - thanks @andschwa and @JustinGrote