Skip to content

Enable TypeScript compiler's strict mode #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
andyleejordan opened this issue Sep 13, 2021 · 2 comments · Fixed by #4206
Closed
2 tasks done

Enable TypeScript compiler's strict mode #3561

andyleejordan opened this issue Sep 13, 2021 · 2 comments · Fixed by #4206
Assignees
@andyleejordan
Labels
Area-Engine Issue-Enhancement A feature request (enhancement).

Comments

@andyleejordan
Copy link
Member

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.

Summary

The following options should be enabled in tsconfig.json:

"strict": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"noUnusedParameters": true

Proposed Design

We'll have to carefully fix all the errors and potential bugs that this reveals.
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Engine labels Sep 13, 2021
@andyleejordan andyleejordan added this to the Consider-vNext milestone Sep 13, 2021
@andyleejordan andyleejordan self-assigned this Sep 13, 2021
@andyleejordan andyleejordan mentioned this issue Sep 13, 2021
Merged
@SydneyhSmith SydneyhSmith moved this to Wishlist in American Pharoah May 9, 2022
@SydneyhSmith SydneyhSmith removed this from the Consider-vNext milestone Aug 11, 2022
@andyleejordan
Copy link
Member Author

I've made progress on this with "use strict"; in most files now!

@andyleejordan
Copy link
Member Author

Getting close...

@andyleejordan andyleejordan mentioned this issue Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyleejordan andyleejordan

Labels
Area-Engine Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable strict TypeScript mode PowerShell/vscode-powershell
2 participants
@andyleejordan @SydneyhSmith