Skip to content

Snippets doesn't follow the new word separator standard #3404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Schillman opened this issue Jun 8, 2021 · 3 comments
Closed

Snippets doesn't follow the new word separator standard #3404

Schillman opened this issue Jun 8, 2021 · 3 comments
Labels
Area-Snippets Issue-Bug A bug to squash. Resolution-Fixed Will close automatically. Up for Grabs Will shepherd PRs.

Comments

@Schillman
Copy link

Schillman commented Jun 8, 2021

System Details Output

### VSCode version: 1.56.2 054a9295330880ed74ceaedda236253b4f39a335 x64

### VSCode extensions:
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]


### PSES version: 2.4.2.0

### PowerShell version:

Name                           Value                                                                                                          
----                           -----                                                                                                          
PSVersion                      5.1.19041.1023                                                                                                 
PSEdition                      Desktop                                                                                                        
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}                                                                                        
BuildVersion                   10.0.19041.1023                                                                                                
CLRVersion                     4.0.30319.42000                                                                                                
WSManStackVersion              3.0                                                                                                            
PSRemotingProtocolVersion      2.3                                                                                                            
SerializationVersion           1.1.0.1                                                                                                        

Issue Description

The Snippet behaviour still matches the old separators. It doesn't select the $ to be replaced when inserting a snippet.
image

Expected Behaviour

I would expect it to match the behaviour of the word separators by default for PowerShell files.

Actual Behaviour

When inserting a snippet, it should not only select the word in the variables, but the entire variable, including '$' as that follows the new standard.

@ghost ghost added the Needs: Triage Maintainer attention needed! label Jun 8, 2021
@andyleejordan andyleejordan added Issue-Bug A bug to squash. Up for Grabs Will shepherd PRs. and removed Needs: Triage Maintainer attention needed! labels Jun 11, 2021
@andyleejordan andyleejordan added this to the Consider-vNext milestone Jun 11, 2021
@andyleejordan
Copy link
Member

Thanks! I've been meaning to look through the snippets, I think they all need a little TLC.

@andyleejordan
Copy link
Member

I believe this was fixed by #3839. Please re-open if not!

@andyleejordan andyleejordan added the Resolution-Fixed Will close automatically. label Mar 31, 2022
@andyleejordan andyleejordan changed the title Snippets doesn't follow the new word separator standard. ``` Snippets doesn't follow the new word separator standard Mar 31, 2022
@andyleejordan andyleejordan moved this to Todo in Sea Biscuit Mar 31, 2022
@andyleejordan andyleejordan moved this from Todo to Done in Sea Biscuit Mar 31, 2022
@ghost ghost closed this as completed Mar 31, 2022
@ghost
Copy link

ghost commented Mar 31, 2022

This issue has been marked as fixed. It has been automatically closed for housekeeping purposes.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Snippets Issue-Bug A bug to squash. Resolution-Fixed Will close automatically. Up for Grabs Will shepherd PRs.
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants