Skip to content

Update Status Bar terminal icon to terminal-powershell icon #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TylerLeonhardt opened this issue May 14, 2021 · 1 comment · Fixed by #3356
Closed

Update Status Bar terminal icon to terminal-powershell icon #3351

TylerLeonhardt opened this issue May 14, 2021 · 1 comment · Fixed by #3356
Assignees
@andyleejordan
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Milestone
Committed-vNext

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented May 14, 2021 •
edited
Loading

As of 1.56 (current latest as of the creation of this issue), there is a terminal-powershell codicon!
image

Feel free to use it everywhere, but a good spot for sure would be replacing terminal here with terminal-powershell:

vscode-powershell/src/session.ts

Line 659 in db40d97

let statusIconText = "$(terminal) ";

@ghost ghost added the Needs: Triage Maintainer attention needed! label May 14, 2021
@andyleejordan
Copy link
Member

Thanks @TylerLeonhardt!

@andyleejordan andyleejordan self-assigned this May 17, 2021
@andyleejordan andyleejordan added this to the Committed-vNext milestone May 17, 2021
@andyleejordan andyleejordan added Area-UI Issue-Enhancement A feature request (enhancement). and removed Needs: Triage Maintainer attention needed! labels May 17, 2021
@andyleejordan andyleejordan mentioned this issue May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyleejordan andyleejordan

Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
Committed-vNext
Development

Successfully merging a pull request may close this issue.

Use PowerShell terminal icon (when available) PowerShell/vscode-powershell
2 participants
@andyleejordan @TylerLeonhardt