Hangs on ArgumentCompleter Debugging #3256

JustinGrote · 2021-01-19T15:53:25Z

Example Code:

using namespace System.Management.Automation
$MSIHelper = {
    param($commandName, $parameterName, $wordToComplete, $commandAst, $fakeBoundParameters)

    if ($GLOBAL:ACDebug) {
        $CommandName | Write-Host -fore darkgreen
        $ParameterName | Write-Host -fore darkcyan
        $wordToComplete | Write-Host -fore darkyellow
        $commandAst | ft | Out-String | Write-Host -fore magenta
        $fakeBoundParameters | ft | out-string | write-host -fore green
    }
    [CompletionResult]::new(
        'test', #completionText
        'testListItem', #listItemText
        [CompletionResultType]::ParameterValue, #resultType
        'testToolTip' #toolTip
    )
}
Register-ArgumentCompleter -CommandName New-AzureADServiceAppRoleAssignment -ScriptBlock $MSIHelper

When dotsourcing this from a file and then starting interactive debug with F5, upon attempting the completion it starts debug and stops at the correct line and displays all the info, however the console is hung and none of the debug buttons (run, step into/out/etc) work. Stop does work, but the integrated console totally hangs and requires a restart.

babysnakes · 2022-01-29T18:38:39Z

Same problem here 🙁

andyleejordan · 2022-01-31T17:38:14Z

@JustinGrote Do you know if this continues to repro with the latest Preview? @babysnakes What version of the extension are you using?

babysnakes · 2022-01-31T19:21:07Z

@andschwa , I'm using current latest (2021.12.0).

Thanks

EDIT: forgot to mention, I'm using PowerShell 7.2 on windows 10.

andyleejordan · 2022-01-31T19:42:32Z

@babysnakes Can you try the latest version of PowerShell Preview for VS Code? Thanks again!

babysnakes · 2022-01-31T20:04:14Z

@andschwa sure, I'll try tomorrow and update.

babysnakes · 2022-02-04T09:11:46Z

@andschwa, Sorry it took me some time 🙁 ...

I installed the latest preview, Imported the completion from file and tried to debug completions. The good news is that I was able to step the debugger. It doesn't seem to produce completion back to the terminal but it's a good start 😄.

Here's the entire output from the terminal:

=====> PowerShell Preview Integrated Console v2022.2.0 <=====

PS C:\Users\haim\Code\Personal\test> Import-Module .\file.ps1
PS C:\Users\haim\Code\Personal\test> asdfw [DBG]: PS C:\Users\haim\Code\Personal\test>
[DBG]: PS C:\Users\haim\Code\Personal\test> 

Oops, something went wrong.
Please report this bug with ALL the details below, including both the 'Environment' and 'Exception' sections.
Please report on GitHub: https://github.com/PowerShell/PSReadLine/issues/new?template=Bug_Report.yaml        
Thank you!

### Environment
PSReadLine: 2.2.0-beta5
PowerShell: 2022.2.0
OS: Microsoft Windows 10.0.19044
BufferWidth: 128
BufferHeight: 11

Last 25 Keys:

 i m p o r t - m o d u Tab Spacebar f i l Tab Enter
 a s d f w Spacebar Tab

### Exception

System.ObjectDisposedException: Safe handle has been closed.
Object name: 'SafeHandle'.
   at System.Runtime.InteropServices.SafeHandle.InternalRelease(Boolean disposeOrFinalizeOperation)
   at System.Runtime.InteropServices.SafeHandle.DangerousRelease()
   at System.Threading.WaitHandle.ObtainSafeWaitHandles(ReadOnlySpan`1 waitHandles, Span`1 safeWaitHandles, Span`1 unsafeWaitHandles)
   at System.Threading.WaitHandle.WaitMultiple(ReadOnlySpan`1 waitHandles, Boolean waitAll, Int32 millisecondsTimeout)
   at System.Threading.WaitHandle.WaitMultiple(WaitHandle[] waitHandles, Boolean waitAll, Int32 millisecondsTimeout)
   at Microsoft.PowerShell.PSConsoleReadLine.ReadKey()
   at Microsoft.PowerShell.PSConsoleReadLine.InputLoop()
   at Microsoft.PowerShell.PSConsoleReadLine.ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics, CancellationToken cancellationToken, Nullable`1 lastRunStatus)


PS C:\Users\haim\Code\Personal\test> asdfw he[DBG]: PS C:\Users\haim\Code\Personal\test> 
[DBG]: PS C:\Users\haim\Code\Personal\test>
[DBG]: PS C:\Users\haim\Code\Personal\test>
[DBG]: PS C:\Users\haim\Code\Personal\test>
[DBG]: PS C:\Users\haim\Code\Personal\test>
[DBG]: PS C:\Users\haim\Code\Personal\test>
[DBG]: PS C:\Users\haim\Code\Personal\test>
[DBG]: PS C:\Users\haim\Code\Personal\test> 

Oops, something went wrong.
Please report this bug with ALL the details below, including both the 'Environment' and 'Exception' sections.
Please report on GitHub: https://github.com/PowerShell/PSReadLine/issues/new?template=Bug_Report.yaml
Thank you!

### Environment
PSReadLine: 2.2.0-beta5
PowerShell: 2022.2.0
OS: Microsoft Windows 10.0.19044
BufferWidth: 128
BufferHeight: 11

Last 34 Keys:

 i m p o r t - m o d u Tab Spacebar f i l Tab Enter
 a s d f w Spacebar Tab a s d f w Spacebar h e Tab

### Exception

System.ObjectDisposedException: Safe handle has been closed.
Object name: 'SafeHandle'.
   at System.Runtime.InteropServices.SafeHandle.InternalRelease(Boolean disposeOrFinalizeOperation)
   at System.Threading.WaitHandle.ObtainSafeWaitHandles(ReadOnlySpan`1 waitHandles, Span`1 safeWaitHandles, Span`1 unsafeWaitHandles)
   at System.Threading.WaitHandle.WaitMultiple(ReadOnlySpan`1 waitHandles, Boolean waitAll, Int32 millisecondsTimeout)
   at System.Threading.WaitHandle.WaitMultiple(WaitHandle[] waitHandles, Boolean waitAll, Int32 millisecondsTimeout)
   at Microsoft.PowerShell.PSConsoleReadLine.ReadKey()
   at Microsoft.PowerShell.PSConsoleReadLine.InputLoop()
   at Microsoft.PowerShell.PSConsoleReadLine.ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics, CancellationToken cancellationToken, Nullable`1 lastRunStatus)

andyleejordan · 2022-02-04T18:06:22Z

Ah ha, that's super useful @babysnakes, it looks like the same thing we're seeing in #3751. Seems like the way we're invoking PSReadLine barfs if it happens under the debugger while it's in the middle of doing something.

babysnakes · 2022-02-05T06:56:27Z

@andschwa , glad I could help. Let me know if there's anything else you want me to try.

andyleejordan · 2022-02-09T19:27:55Z

Ditto #3751 (comment) @babysnakes and @JustinGrote. Can you try again?

andyleejordan · 2022-02-09T20:28:53Z

Marking as fixed, if it does still repro, please let me know, and re-open it!

ghost · 2022-02-09T22:00:48Z

This issue has been marked as fixed. It has been automatically closed for housekeeping purposes.

babysnakes · 2022-02-10T13:44:53Z

@andschwa, I don't see any new plugin version (or github release). The last one is from over a week ago (02/02/22 - v2022.2.0). Is there going to be a new preview release soon?

andyleejordan · 2022-02-10T17:59:47Z

Yes, that version of the PowerShell Preview extension is what I tested. It has the fix I mentioned (PowerShell/PowerShellEditorServices#1690) and I can no longer repro this bug report (where I could previously).

babysnakes · 2022-02-10T19:20:36Z

@andschwa, here's the output from the debugging completion terminal. It's similar to before. Note that the current state of debugging completion script is good enough for me. I don't need the output to be printed to the console:

=====> PowerShell Preview Integrated Console v2022.2.0 <=====

PS C:\Users\haim\Code\Personal\roon-tagger> ipmo .\src\RoonTagger.Cli\Resources\Completions\roon-tagger-completion.ps1
PS C:\Users\haim\Code\Personal\roon-tagger> roon-tagger c[DBG]: PS C:\Users\haim\Code\Personal\roon-tagger> 
[DBG]: PS C:\Users\haim\Code\Personal\roon-tagger> 
[DBG]: PS C:\Users\haim\Code\Personal\roon-tagger> 
[DBG]: PS C:\Users\haim\Code\Personal\roon-tagger> 

Oops, something went wrong.
Please report this bug with ALL the details below, including both the 'Environment' and 'Exception' sections.
Please report on GitHub: https://github.com/PowerShell/PSReadLine/issues/new?template=Bug_Report.yaml
Thank you!

### Environment
PSReadLine: 2.2.0-beta5
PowerShell: 2022.2.0
OS: Microsoft Windows 10.0.19044
BufferWidth: 115
BufferHeight: 11

Last 56 Keys:

 i m Backspace p m o Spacebar s r Tab r o Tab r e s Tab c o m Tab Tab Enter
 r o o n - t a g g e r Spacebar c Tab Tab Tab Ctrl+u Ctrl+a Backspace r o o n - t a g g e r Spacebar c Tab

### Exception

System.ObjectDisposedException: Safe handle has been closed.
Object name: 'SafeHandle'.
   at System.Runtime.InteropServices.SafeHandle.InternalRelease(Boolean disposeOrFinalizeOperation)
   at System.Runtime.InteropServices.SafeHandle.DangerousRelease()
   at System.Threading.WaitHandle.ObtainSafeWaitHandles(ReadOnlySpan`1 waitHandles, Span`1 safeWaitHandles, Span`1 
unsafeWaitHandles)
   at System.Threading.WaitHandle.WaitMultiple(ReadOnlySpan`1 waitHandles, Boolean waitAll, Int32 millisecondsTimeout)
   at System.Threading.WaitHandle.WaitMultiple(WaitHandle[] waitHandles, Boolean waitAll, Int32 millisecondsTimeout)
   at Microsoft.PowerShell.PSConsoleReadLine.ReadKey()
   at Microsoft.PowerShell.PSConsoleReadLine.InputLoop()
   at Microsoft.PowerShell.PSConsoleReadLine.ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics, CancellationToken cancellationToken, Nullable`1 lastRunStatus)


PS C:\Users\haim\Code\Personal\roon-tagger> 
PS C:\Users\haim\Code\Personal\roon-tagger>

andyleejordan · 2022-02-10T20:29:44Z

@babysnakes Can you share the script you're debugging that's causing that?

babysnakes · 2022-02-10T20:36:31Z

@andschwa sure. here.

andyleejordan · 2022-02-10T20:43:30Z

Working fine so far.

andyleejordan · 2022-02-10T20:45:35Z

Ah ha, on pressing Continue it errors:

> roon-tagger credits --a[DBG] @andys-mac-mini ~/src 
>      

Oops, something went wrong.
Please report this bug with ALL the details below, including both the 'Environment' and 'Exception' sections.
Please report on GitHub: https://github.com/PowerShell/PSReadLine/issues/new?template=Bug_Report.yaml
Thank you!

### Environment
PSReadLine: 2.2.0-beta5
PowerShell: 2022.2.0
OS: Darwin 21.3.0 Darwin Kernel Version 21.3.0: Wed Jan  5 21:37:58 PST 2022; root:xnu-8019.80.24~20/RELEASE_ARM64_T8101
BufferWidth: 151
BufferHeight: 32

Last 200 Keys:

 Tab Backspace Backspace Backspace - Tab Tab Backspace / s r c / R o o n T a g g e r . C l i / b i n / D e b u g / n e t 5 . 0 / Ctrl+a Ctrl+a Ctrl+f Ctrl+f Ctrl+f Ctrl+f Ctrl+f Ctrl+f Ctrl+f Ctrl+f Ctrl+f Ctrl+f . Enter
 r o o n t - a Backspace Backspace Backspace - t a g Tab Enter
 r o o n - t a g g e r Spacebar - - Tab v Tab Tab s Tab Ctrl+a Ctrl+k r o o n - t a g Tab Spacebar Backspace Ctrl+a Ctrl+k r o o n t Backspace - t a g g e r Spacebar c Tab r Tab Ctrl+a Ctrl+k r o o n - t a g g e r Spacebar c Tab r Tab Spacebar - - Tab c Enter
 c l e a r Enter
 UpArrow UpArrow UpArrow Spacebar c r Tab Spacebar - - a Tab s Backspace Tab Tab Tab Ctrl+u Ctrl+a l s Backspace Ctrl+a Ctrl+e Ctrl+w l k j a d Ctrl+a Ctrl+e Ctrl+a Ctrl+k l k j a Backspace Backspace Backspace Backspace

### Exception

System.ObjectDisposedException: Safe handle has been closed.
Object name: 'SafeHandle'.
   at System.Runtime.InteropServices.SafeHandle.InternalRelease(Boolean disposeOrFinalizeOperation)
   at System.Threading.WaitHandle.ObtainSafeWaitHandles(ReadOnlySpan`1 waitHandles, Span`1 safeWaitHandles, Span`1 unsafeWaitHandles)
   at System.Threading.WaitHandle.WaitMultiple(ReadOnlySpan`1 waitHandles, Boolean waitAll, Int32 millisecondsTimeout)
   at Microsoft.PowerShell.PSConsoleReadLine.ReadKey()
   at Microsoft.PowerShell.PSConsoleReadLine.InputLoop()
   at Microsoft.PowerShell.PSConsoleReadLine.ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics, CancellationToken cancellationToken, Nullable`1 lastRunStatus)

babysnakes · 2022-02-10T21:04:29Z

@andschwa yeah, sorry, I didn't explain myself correctly ...

andyleejordan · 2022-02-10T21:07:07Z

No worries! That's why it's helpful to have enough repro info for me to step through it all. This helps narrow it down. I'll get a debugger attached and see what's happening when I press "Continue" that ReadLine barfs.

SydneyhSmith transferred this issue from PowerShell/PowerShellEditorServices Mar 23, 2021

ghost added the Needs: Triage Maintainer attention needed! label Mar 23, 2021

SydneyhSmith added Area-Debugging Issue-Bug A bug to squash. and removed Needs: Triage Maintainer attention needed! labels Mar 23, 2021

ghost added the Needs: Maintainer Attention Maintainer attention needed! label Jan 29, 2022

andyleejordan added Needs: Author Feedback Please give us the requested feedback! and removed Needs: Maintainer Attention Maintainer attention needed! labels Jan 31, 2022

ghost added Needs: Maintainer Attention Maintainer attention needed! and removed Needs: Author Feedback Please give us the requested feedback! labels Jan 31, 2022

StevenBucher98 added Needs: Author Feedback Please give us the requested feedback! and removed Needs: Maintainer Attention Maintainer attention needed! labels Feb 1, 2022

andyleejordan added this to Sea Biscuit Feb 4, 2022

andyleejordan moved this to Todo in Sea Biscuit Feb 4, 2022

andyleejordan moved this from Todo to In Progress in Sea Biscuit Feb 9, 2022

andyleejordan added Needs: Fix Verification Please verify the fix for us! Resolution-Fixed Will close automatically. and removed Needs: Author Feedback Please give us the requested feedback! labels Feb 9, 2022

ghost closed this as completed Feb 9, 2022

Repository owner moved this from In Progress to Done in Sea Biscuit Feb 9, 2022

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hangs on ArgumentCompleter Debugging #3256

Hangs on ArgumentCompleter Debugging #3256

JustinGrote commented Jan 19, 2021

babysnakes commented Jan 29, 2022

andyleejordan commented Jan 31, 2022

babysnakes commented Jan 31, 2022 •

edited

Loading

andyleejordan commented Jan 31, 2022

babysnakes commented Jan 31, 2022

babysnakes commented Feb 4, 2022

andyleejordan commented Feb 4, 2022

babysnakes commented Feb 5, 2022

andyleejordan commented Feb 9, 2022

andyleejordan commented Feb 9, 2022

ghost commented Feb 9, 2022

babysnakes commented Feb 10, 2022

andyleejordan commented Feb 10, 2022 •

edited

Loading

babysnakes commented Feb 10, 2022

andyleejordan commented Feb 10, 2022

babysnakes commented Feb 10, 2022

andyleejordan commented Feb 10, 2022

andyleejordan commented Feb 10, 2022

babysnakes commented Feb 10, 2022

andyleejordan commented Feb 10, 2022

Hangs on ArgumentCompleter Debugging #3256

Hangs on ArgumentCompleter Debugging #3256

Comments

JustinGrote commented Jan 19, 2021

babysnakes commented Jan 29, 2022

andyleejordan commented Jan 31, 2022

babysnakes commented Jan 31, 2022 • edited Loading

andyleejordan commented Jan 31, 2022

babysnakes commented Jan 31, 2022

babysnakes commented Feb 4, 2022

andyleejordan commented Feb 4, 2022

babysnakes commented Feb 5, 2022

andyleejordan commented Feb 9, 2022

andyleejordan commented Feb 9, 2022

ghost commented Feb 9, 2022

babysnakes commented Feb 10, 2022

andyleejordan commented Feb 10, 2022 • edited Loading

babysnakes commented Feb 10, 2022

andyleejordan commented Feb 10, 2022

babysnakes commented Feb 10, 2022

andyleejordan commented Feb 10, 2022

andyleejordan commented Feb 10, 2022

babysnakes commented Feb 10, 2022

andyleejordan commented Feb 10, 2022

babysnakes commented Jan 31, 2022 •

edited

Loading

andyleejordan commented Feb 10, 2022 •

edited

Loading