Skip to content

Default dark color scheme is broken #3220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GreatTeacherBasshead opened this issue Mar 3, 2021 · 2 comments
Closed

Default dark color scheme is broken #3220

GreatTeacherBasshead opened this issue Mar 3, 2021 · 2 comments

Comments

@GreatTeacherBasshead
Copy link

Environment

  • Editor: VS Code
  • Version: 1.53.2 (system setup)
  • Commit: 622cb03f7e070a9670c94bae1a45d78d7181fbd4
  • Date: 2021-02-11T11:48:04.245Z
  • Electron: 11.2.1
  • Chrome: 87.0.4280.141
  • Node.js: 12.18.3
  • V8: 8.7.220.31-electron.0
  • OS: Windows_NT x64 10.0.19041
  • Your primary theme: Dark+ (default dark)

Issue Description

After enabling ms-vscode.powershell extension the default dark color scheme shows different (not as good) colors.
When I disable the extension it works as expected.
Also when I execute Restart current [PowerShell] session, while its restarting it shows expected colors. Once restarted, the colors are "broken" again.

Screenshots

expected
actual

Expected Behavior

-Path displayed in white color.
$destination displayed in blue color.

Actual Behavior

-Path displayed in blue color.
$destination displayed in blue color.

Code Samples

New-Item -Path $destination
@andyleejordan
Copy link
Member

This is due to a change in the extension to use "semantic highlighting" in addition to (and on top of) the editor syntax provided by this repo. With the extension enabled, the highlighting scheme changes (and it appears to need some work). See some related discussion here: #3211

@andyleejordan andyleejordan transferred this issue from PowerShell/EditorSyntax Mar 3, 2021
@ghost ghost added the Needs: Triage Maintainer attention needed! label Mar 3, 2021
@SydneyhSmith SydneyhSmith added Resolution-Answered Will close automatically. and removed Needs: Triage Maintainer attention needed! labels Mar 9, 2021
@ghost ghost closed this as completed Mar 10, 2021
@peetrike
Copy link

As a workaround, You can add next section to settings.json

  "editor.semanticTokenColorCustomizations": {
    "[Default Dark+]": {
      "rules": {
          // make it different from variable
        "parameter": "#d4d4d4"
      }
    }
  },

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Apr 28, 2021
@SydneyhSmith SydneyhSmith removed the Needs: Maintainer Attention Maintainer attention needed! label May 18, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants