Skip to content

Extension name is hardcoded, leading to failing tests #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andyleejordan opened this issue Feb 25, 2021 · 0 comments · Fixed by #3222
Closed

Extension name is hardcoded, leading to failing tests #3208

andyleejordan opened this issue Feb 25, 2021 · 0 comments · Fixed by #3222
Assignees
@andyleejordan
Labels
Area-Test Issue-Bug A bug to squash.
Milestone
Committed-vNext

Comments

@andyleejordan
Copy link
Member

When the extension name is switched from powershell-preview to just powershell (such as when releasing a stable version like in #3207), the tests fail because of hardcoded constants like const testExtensionId = "ms-vscode.powershell-preview";. We should instead read the current extension ID from the package.json file, which is already done in main.ts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyleejordan andyleejordan

Labels
Area-Test Issue-Bug A bug to squash.
Projects
None yet
Milestone
Committed-vNext
Development

Successfully merging a pull request may close this issue.

Fix hardcoded extension name string PowerShell/vscode-powershell
1 participant
@andyleejordan