-
Notifications
You must be signed in to change notification settings - Fork 510
Remove Notebook API support #3176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yeah I think the key issue for us is that we had assumed the VSCode notebook APIs would stabilise sooner than it has, so it was acceptable to take the incremental changes in the meantime. We've proven the concept (and helped VSCode develop their API), but managing the update PRs has become an ongoing burden — the simplest solution is for us to wait for the API to be exposed stably by VSCode and then to re-enable our notebook integration code. |
That "feature branch" is just the fact that it's in the history as a merged PR 😅 |
Damn, I was just sitting down to finally play with this lol. |
It'll come back one day! Just when the VS Code API is stable and we can integrate with it properly. For now, we're focussing on much-needed stabilization work for the extension. 😄 |
What are the current status of the VS Code API and plans to integrate the Notebook API? |
Thank you for your comment, but please note that this issue has been closed for over a week. For better visibility, consider opening a new issue with a link to this instead. |
The Notebook API support was partially implemented but based on early Visual Studio Code APIs which have yet to be finalized. Since our support is experimental, it probably ought to have been in a feature branch. So we're planning to:
/cc @TylerLeonhardt @rjmholt @SydneyhSmith
The text was updated successfully, but these errors were encountered: