Skip to content

Full type name when using ctrl+space #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PrzemyslawKlys opened this issue Aug 20, 2020 · 5 comments · Fixed by PowerShell/PowerShellEditorServices#1352
Closed

Full type name when using ctrl+space #2898

PrzemyslawKlys opened this issue Aug 20, 2020 · 5 comments · Fixed by PowerShell/PowerShellEditorServices#1352
Labels
Area-IntelliSense Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@PrzemyslawKlys
Copy link
Contributor

Summary of the new feature

Right now when you type in [SomeType] and try to tab ctrl+space complete it displays list of types which is great, but it's a short type name. I often have to go thru 2-5 different types before I pick the correct one I want. Can you maybe allow a choice between short (if you want to keep old version) and full type?

image

or

image

@ghost ghost added the Needs: Triage Maintainer attention needed! label Aug 20, 2020
@TylerLeonhardt
Copy link
Member

I think it seems reasonable that the tooltip for types can include the full type name.

@SydneyhSmith SydneyhSmith added Area-IntelliSense Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs. and removed Needs: Triage Maintainer attention needed! labels Aug 20, 2020
@TylerLeonhardt
Copy link
Member

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Aug 21, 2020

I'd also want a test added for this. That's fairly straightforward.

  1. Add an incomplete type name at the end of here: https://github.com/PowerShell/PowerShellEditorServices/blob/master/test/PowerShellEditorServices.Test.Shared/Completion/CompletionExamples.psm1 (something like [System.Collections.)
  2. Create a new class (CompleteTypeName) that looks like: https://github.com/PowerShell/PowerShellEditorServices/blob/master/test/PowerShellEditorServices.Test.Shared/Completion/CompleteCommandFromModule.cs (note line 33 is the tooltip, so the value of that would be the full type name)
  3. Copy this test but use your new class

Running the tests is easy. Run Invoke-Build Build,TestServer in the PSES directory.

@TylerLeonhardt
Copy link
Member

This will be in the next preview thanks to @AspenForester!

@PrzemyslawKlys
Copy link
Contributor Author

Wohoo :-D Thank you @AspenForester

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Sep 9, 2020
@TylerLeonhardt TylerLeonhardt removed the Needs: Maintainer Attention Maintainer attention needed! label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IntelliSense Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants