Notebook Mode: The comment block is not recognized as a Markdown block

[mkht]

Well, can I post any feedback on the Notebook mode that Tyler Leonhardt has posted on the PowerShell blog?
https://devblogs.microsoft.com/powershell/public-preview-of-notebook-mode-in-the-powershell-preview-extension-for-visual-studio-code/

Issue Description

The comment block style that our team normally uses doesn't seem to be correctly parsed as a Markdown block in the Nodebook mode.

<# =========================
# Write comment here
============================ #>

I hope this is improved.

Text mode

Notebook mode

[TylerLeonhardt]

That's odd. That should work. Do normal block comments work?

<#
Foo
#>

[mkht]

Hi @TylerLeonhardt
Yes, normal block comments are working fine.

[rjmholt]

What about this one:

<# x
 # Comment
#>

or this one:

<#
 # Comment
x #>

Or

<#
 # Comment
    #>

(Spacing before the end delimiter)

[TylerLeonhardt]

I bet the first case is broken

[rjmholt]

The code indicates that we expect the whole line to be the comment delimiter, rather than just contain it:

vscode-powershell/src/features/PowerShellNotebooks.ts

Line 125 in 2d30df7

} else if (lines[i] === "<#") {

vscode-powershell/src/features/PowerShellNotebooks.ts

Line 100 in 2d30df7

if (lines[i] === "#>") {

[mkht]

Unfortunately, this is not good in all three cases.
Is this an issue specific to my environment? Is everyone OK?

Case 1

Case 2

Case 3

[rjmholt]

Is this an issue specific to my environment?

It's a general bug that we'll fix in the next update. For now cells must start with the line <# and end with the line #>

[TylerLeonhardt]

Yep, should be a straightforward fix and you've given us a great test case :)