Skip to content

Remove codeFormatting.whitespaceAroundPipe setting for users in next stable version #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bergmeister opened this issue May 12, 2020 · 1 comment · Fixed by #2830
Closed

Remove codeFormatting.whitespaceAroundPipe setting for users in next stable version #2693

bergmeister opened this issue May 12, 2020 · 1 comment · Fixed by #2830
Labels
Area-Code Formatting Area-Configuration

Comments

@bergmeister
Copy link
Contributor

bergmeister commented May 12, 2020 •
edited
Loading

In PR #2689 we make the extension migrate the value of codeFormatting.whitespaceAroundPipe to codeFormatting.addWhitespaceAroundPipe for the next preview.
Before the next stable release, we should modify the logic to also remove the codeFormatting.whitespaceAroundPipe setting, which will be redundant from then on.
@ghost ghost added the Needs: Triage Maintainer attention needed! label May 12, 2020
@bergmeister bergmeister mentioned this issue May 12, 2020
Merged
4 tasks
@SydneyhSmith SydneyhSmith added Area-Code Formatting Issue-Bug A bug to squash. Area-Configuration and removed Needs: Triage Maintainer attention needed! labels May 12, 2020
@bergmeister
Copy link
Contributor Author

bergmeister commented May 14, 2020 •
edited
Loading

@SydneyhSmith This is not a bug. This is the 2nd part of the migration plan to migrate a deprecated setting to the newer one automatically for the user. A PR for this cannot be merged until after the last preview before the next stable release.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label May 14, 2020
@TylerLeonhardt TylerLeonhardt added Issue-Meta and removed Issue-Bug A bug to squash. Needs: Maintainer Attention Maintainer attention needed! labels May 14, 2020
@bergmeister bergmeister mentioned this issue Jul 23, 2020
Merged
4 tasks
@ghost ghost added the Status: In PR label Jul 23, 2020
@ghost ghost added Status: Fixed and removed Status: In PR labels Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Code Formatting Area-Configuration
Projects
None yet
Milestone
No milestone
3 participants
@TylerLeonhardt @bergmeister @SydneyhSmith