Skip to content

Enable semanticHighlighting in PowerShell ISE theme #2656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aeschli opened this issue Apr 23, 2020 · 3 comments
Closed

Enable semanticHighlighting in PowerShell ISE theme #2656

aeschli opened this issue Apr 23, 2020 · 3 comments
Labels
Area-UI Issue-Enhancement A feature request (enhancement).

Comments

@aeschli
Copy link
Contributor

aeschli commented Apr 23, 2020

Since 1.43, VSCode themes can take advantage of semantic highlighting.

Every theme controls whether semantic tokens are enabled. So far, only built-in themes have it enabled and I filed this issue to ask you to opt-in for the PowerShell ISE theme as well.

Adoption is easy and there are new cool styling possibilities.

To turn on semantic highlighting for you theme, all you have to do is put
"semanticHighlighting": true
in the theme definition file.

There's a good chance that no further change to the theme is needed (thanks to a default mapping from semantic tokens to TextMate scopes (if not, I'd be interested to know, so I can improve the defaults further)).

But, more interestingly, themes can tune and go wild by defining new styling rules against the semantic tokens:

"semanticTokenColors": {
    "variable.readonly": "#ff0000", 
    "parameter": { "fontStyle": "underline" },
    "*.declaration:java": { "fontStyle": "bold" }
} 

Check out our Semantic Highlighting Wiki and the Semantic Highlighting Guide for more details and feel free to ping me in this issue if I can help.

@ghost ghost added the Needs: Triage Maintainer attention needed! label Apr 23, 2020
@TylerLeonhardt
Copy link
Member

Just for clarity - this is to support languages that support semanticHighlighting, yes? Not to support semantic highlighting in PowerShell (which we also wanna do when the LSP API is stable)

@aeschli
Copy link
Contributor Author

aeschli commented Apr 23, 2020

Right, this is actually just for the theme (I'm contacting all the top theme authors).
If your theme only make sense to be used with Powershell, then you can ignore the request until Powershell also has semantic highlighting.

@SydneyhSmith SydneyhSmith added Area-UI Issue-Enhancement A feature request (enhancement). and removed Needs: Triage Maintainer attention needed! labels Apr 23, 2020
@TylerLeonhardt
Copy link
Member

Fixed in #2834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

3 participants