Skip to content

Debug command/abort race condition causes bad state in PSES #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rjmholt opened this issue Feb 28, 2020 · 4 comments
Closed

Debug command/abort race condition causes bad state in PSES #2508

rjmholt opened this issue Feb 28, 2020 · 4 comments
Labels
Area-Debugging Issue-Bug A bug to squash. Resolution-Fixed Will close automatically.

Comments

@rjmholt
Copy link
Contributor

rjmholt commented Feb 28, 2020

From PowerShell/PowerShellEditorServices#1210.

While PowerShell/PowerShellEditorServices#1210 patches this, it is likely to not be enough to fully prevent the issues occurring here.

Instead we need to sift through the interaction between the debugger, PSReadLine and the PowerShellContextService to ensure that our internal conceptual state machine makes sense and that the way multiple threads interact with the state of PowerShell is sensible and well-defined.

@andyleejordan
Copy link
Member

I'm going to move this to the Editor Services Pipeline project, as that's really the meat of this issue.

@andyleejordan
Copy link
Member

@rjmholt Think this should stay open?

@rjmholt
Copy link
Contributor Author

rjmholt commented Oct 29, 2021

Time to close I think. Problems that persist here will be sufficiently new to merit a new issue

@andyleejordan andyleejordan added the Resolution-Fixed Will close automatically. label Oct 29, 2021
@ghost ghost closed this as completed Nov 3, 2021
@ghost
Copy link

ghost commented Nov 3, 2021

This issue has been marked as fixed. It has been automatically closed for housekeeping purposes.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Debugging Issue-Bug A bug to squash. Resolution-Fixed Will close automatically.
Projects
None yet
Development

No branches or pull requests

2 participants