Skip to content

Use new language status items API for status bar info #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tyriar opened this issue Feb 26, 2020 · 3 comments · Fixed by #3869
Closed

Use new language status items API for status bar info #2499

Tyriar opened this issue Feb 26, 2020 · 3 comments · Fixed by #3869
Labels
Area-UI Issue-Enhancement A feature request (enhancement).

Comments

@Tyriar
Copy link
Contributor

Tyriar commented Feb 26, 2020

PowerShell uses the very right of the right status bar to show both initializing and version number:

image

image

This is bad since it makes the status bar unstable; all items left of the PS item will shift to the left and again to the right. I suggest aligning with the TS extension and show the initializing item on the right side of the left status bar:

image

image

Also getting closer to the wording of the TS extension might be a good idea; "Initializing PS language features" or "Initializing PS session" (no "...")?

Related: #2436

@ghost ghost added the Needs: Triage Maintainer attention needed! label Feb 26, 2020
@SydneyhSmith SydneyhSmith added Area-UI Issue-Enhancement A feature request (enhancement). and removed Needs: Triage Maintainer attention needed! labels Feb 27, 2020
@andyleejordan
Copy link
Member

While I want to say we should wait on microsoft/vscode#129037, it will be long between that being finalized, implemented, and then subsequently stabilized such that we can drop all the old code that I think we should at least improve the existing code somewhat and fix this issue.

@andyleejordan andyleejordan added this to the Consider-vNext milestone Sep 22, 2021
@andyleejordan andyleejordan moved this to Todo in Sea Biscuit Feb 28, 2022
@andyleejordan andyleejordan moved this from Todo to Wishlist in Sea Biscuit Feb 28, 2022
@andyleejordan andyleejordan changed the title PS should align with the TS extension on version and initializing status bar indicators Use new language status items API for status bar info Mar 4, 2022
@andyleejordan
Copy link
Member

Yay, the new awesome new API is out!

@andyleejordan andyleejordan moved this from Wishlist to In Progress in Sea Biscuit Mar 10, 2022
@andyleejordan
Copy link
Member

It took a while, but we got it! Thanks @Tyriar.

Repository owner moved this from In Progress to Done in Sea Biscuit Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants