Skip to content

Flag machine specific configurations like paths as machine scoped #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sandy081 opened this issue Jun 14, 2019 · 7 comments · Fixed by #2039
Closed

Flag machine specific configurations like paths as machine scoped #2024

sandy081 opened this issue Jun 14, 2019 · 7 comments · Fixed by #2039
Assignees
Labels
Area-Workspaces Feature: VS Code Request to use or implement a VS Code feature. Issue-Enhancement A feature request (enhancement).

Comments

@sandy081
Copy link

I am developer from VS Code and we introduced Machine Scope for configurations in 1.34 which will help in remote set ups.

I would like to encourage extension authors to adopt to machine scope if you have any settings that you think they are scoped to machine like powershell.powerShellExePath

For example, If you have settings that allow users to customize an executable path that exists on the machine in which extension is running, then you can tag such settings as machine scoped. This will let VS Code to read this setting from the location where the extension is running.

  • When extension is running locally, VS Code reads this setting only from User settings on the same machine.
  • When extension is running remotely, VS Code reads this setting only from Remote settings on the remote machine.

If the extension is running remotely in a remote set up, then this will help the extension not to read paths configured in local machine user settings and bail as the paths not exist in the remote machine.

Note that machine scoped settings are overridable only in user or remote settings.

@rjmholt
Copy link
Contributor

rjmholt commented Jun 14, 2019

@sandy081 would you be able to link to your documentation for how we adopt this scoping?

@rkeithhill
Copy link
Contributor

Was just trying WSL Debug with PowerShell in today's VSCode Insider build and got this:

image

@sandy081 Is this what we can expect from 1.36 when it ships unless we make this change?

@rkeithhill
Copy link
Contributor

Nevermind. Helps if you install the extension in the WSL Remote for Insiders. 🤦‍♂

@sandy081
Copy link
Author

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jun 17, 2019

@sandy081 in the WSL remote development, is WSL still considered "remote and not technically this machine"?

@sandy081
Copy link
Author

No, it is considered remote and paths varies in WSL.

@TylerLeonhardt
Copy link
Member

Right, what I'm getting at is that marking something as "machine" scoped so the setting is marked "different in remote scenarios" is confusing since WSL is still on the same machine.

Apologies if this came off as bike-shedding, but I was confused by the ask initially and didn't want customers to be confused as well.

Something like "host" might have been a better name, IMO.

Anyway, we'll mark our settings that pertain to executable paths as scope:"machine" 👍

@SydneyhSmith SydneyhSmith added Area-Workspaces Issue-Enhancement A feature request (enhancement). Feature: VS Code Request to use or implement a VS Code feature. and removed Triage labels Jun 18, 2019
@TylerLeonhardt TylerLeonhardt mentioned this issue Jun 20, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Workspaces Feature: VS Code Request to use or implement a VS Code feature. Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants