restarting Integrated Console does not respect powershell.powerShellDefaultVersion setting

[fbehrens]

System Details

System Details Output

### VSCode version: 1.28.1 3368db6750222d319c851f6d90eb619d886e08f5 x64

### VSCode extensions:
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]


### PSES version: 1.9.0.0

### PowerShell version:

Name                           Value
----                           -----
PSVersion                      5.1.14393.2485
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.2485
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Issue Description

I have set the setting"powershell.powerShellDefaultVersion": "Windows PowerShell (x86)"

When I start code and the Powershell Integrated Terminal is and shows the correct Version(5.1 (x86))

When I kill the Terminal

and say YES, I like to restart it.

I am not getting an Windows PowerShell (x86) ,

but a 64bit

Attached Logs

Here are diagnostics log
logs.zip

[rjmholt]

It looks like this is deliberate:

vscode-powershell/src/session.ts

Lines 286 to 299 in 0388343

	// If powershell.powerShellDefaultVersion specified, attempt to find the PowerShell exe path
	// of the version specified by the setting.
	if ((this.sessionStatus === SessionStatus.NeverStarted) && this.sessionSettings.powerShellDefaultVersion) {
	const powerShellExePaths = getAvailablePowerShellExes(this.platformDetails, this.sessionSettings);
	const powerShellDefaultVersion =
	powerShellExePaths.find((item) => item.versionName === this.sessionSettings.powerShellDefaultVersion);
	if (powerShellDefaultVersion) {
	powerShellExePath = powerShellDefaultVersion.exePath;
	} else {
	this.log.writeWarning(
	`Could not find powerShellDefaultVersion: '${this.sessionSettings.powerShellDefaultVersion}'`);
	}
	}

@rkeithhill do you know what powerShellDefaultVersion is supposed to mean here? Is this a by-design scenario?

@fbehrens If you set the powershellExePath setting instead, that will be honoured.

[rkeithhill]

From the configuration comments:

  // Specifies the name of the PowerShell version used in the startup session 
  // when the extension loads e.g "Windows PowerShell (x86)" or "PowerShell Core 6.0.2 (x64)".
  "powershell.powerShellDefaultVersion": "",

The above is a true "user" preference while this:

  // Specifies the full path to a PowerShell executable. Changes the installation 
  // of PowerShell used for language and debugging services.
  "powershell.powerShellExePath": "",

is what the "extension" uses to store the last selected PowerShell version's path.

[eedwards-sk]

I just ran into this while using multiple powershell versions.

    "powershell.powerShellAdditionalExePaths": [
        {
            "exePath": "/usr/local/bin/pwsh",
            "versionName": "pwsh"
        },
        {
            "exePath": "/usr/local/bin/pwsh-preview",
            "versionName": "pwsh-preview"
        }
    ],
    "powershell.powerShellDefaultVersion": "pwsh-preview"

after closing the integrated terminal using the trashcan, and re-opening it using the warning dialog (as per the issue author), it loads pwsh instead of pwsh-preview:

> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.2.2
PSEdition                      Core
GitCommitId                    6.2.2
OS                             Darwin 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

[davesbrown]

seems to be loading 7 by default even when changing
"powershell.powerShellDefaultVersion": "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe"

Some more digging: using the settings ui both 5.1 and 7 have a
Switch to: Powershell (x64)

only after being in 7.0 will you see that you are in current session of 7.0

The two different settings used in the settings.json are:
PowerShell (x64)
Windows Powershell (x64)

[rjmholt]

seems to be loading 7 by default even when changing
"powershell.powerShellDefaultVersion": "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe"

The default needs to be specified by name rather than path; try:

"powerShell.powerShellDefaultVersion": "Windows PowerShell (x64)"

[TylerLeonhardt]

The original issue is fixed now. If you still see this behavior please let us know.