-
Notifications
You must be signed in to change notification settings - Fork 511
EditorServices Crash - ERRORS caught while waiting for EditorServicesHost to complete execution #1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EditorServices Crash - ERRORS caught while waiting for EditorServicesHost to complete execution #1492
Comments
@PrzemyslawKlys do you have a small reproducible scenario at all? What were doing when the crash happened? |
Unfortunately it doesn't happen a lot. It happend 3 times so far in 2 days. I believe in last case it just happend. I was typing something in VSCode, maybe doing CTRL C+V and it simply crashed. But it as well cane be related to those 2 things:
|
Understood. I'm pretty certain it's a race condition. I'll need to look into it as part of broader work on the extension (getting threading right generally), so the fix is unlikely to be simple or immediate. |
Happend again:
Was just editing some code. Stopped, was looking at something else and noticed it crashed. |
And another one:
Let me know if you want me to keep on adding as i encounter those or it's enough for now (maybe you need full log as well). I guess without reproducible case it's not gonna be easy/nessecary. One more thing that I do common is having 3+ VS Code windows with 3 different projects open at all times. |
This information seems like enough to go on for now -- it looks like the file offset in VSCode is not synchronised with the actual file. It's the kind of thing that may be difficult to implement correctly, but we should still catch the error and just move on. |
I am experiencing what I believe to be the same issue, several times a day. Logs and environment info attached below Attached LogsEditorServices.log
vscode-powershell.log
Environment InformationVisual Studio Code
PowerShell Information
Visual Studio Code ExtensionsVisual Studio Code Extensions(Click to Expand)
|
Let me know if you want me to try reproducing with verbose logging enabled. |
Hi @csandfeld, I think the logging has identified where in the code the issue is, but won't help us identify why. Can you describe anything about how you were modifying the script when the extension crashed? |
Hi @rjmholt I ran into this issue several times today, while testing some enums, classes, functions, and C# code (with Add-Type). I loaded a file holding the enums and classes, and a number of files each holding a function, into the active session using F5 (so running the debugger, but without doing any actual debugging). Then while typing a variable name ($whatever) in some test code, it would crash. Did that several times in a row. |
The variable name was at the end of the file right? Was the file a new untitled file? Or a modification of one changed on the filesystem? |
Ok, I think I've got this one fixed |
@rjmholt: Yes, the edit was at or towards the end of the file (there may or may not have been some line breaks after), and it was a modification of an existing file. |
System Details
$PSVersionTable
:Issue Description
I am experiencing a problem with... Editor Services crashing.
Attached Logs
Follow the instructions in the README
about capturing and sending logs.
1534771635-da9828e6-52a6-47a2-a062-a301bcd324121534770956637.zip
The text was updated successfully, but these errors were encountered: