Fix Package task

This now leaves the VSIX named as `vsce` creates it:
`powershell-YYYY.MM.X.vsix`, instead of renaming it `PowerShell-Insiders.vsix`.
I can't think of anything this would break, since the upload is not actually
done with the deleted `Upload` task but with an ADO pipeline task.

This also fixes the path to `InvokePesterStub.ps1` which is now part of the
PowerShellEditorServices repository. This was necessary in order to sign it, as
it must be signed _before_ the VSIX is created. Moving it to the other repo was
the best way to solve the "chicken-egg" problem that presented.

Author: andyleejordan

.vsts-ci/templates/release-general.yml

@@ -42,7 +42,6 @@ steps:
     # NOTE: Code AKA *.vsix files are not signed
     pattern: |
       Install-VSCode.ps1
-      InvokePesterStub.ps1
 
 - template: EsrpScan.yml@ComplianceRepo
   parameters:

src/features/PesterTests.ts

@@ -18,7 +18,7 @@ export class PesterTestsFeature implements vscode.Disposable {
     private invokePesterStubScriptPath: string;
 
     constructor(private sessionManager: SessionManager) {
-        this.invokePesterStubScriptPath = path.resolve(__dirname, "../../../InvokePesterStub.ps1");
+        this.invokePesterStubScriptPath = path.resolve(__dirname, "../../../modules/PowerShellEditorServices/InvokePesterStub.ps1");
 
         // File context-menu command - Run Pester Tests
         this.command = vscode.commands.registerCommand(

vscode-powershell.build.ps1

@@ -36,14 +36,6 @@ task ResolveEditorServicesPath -Before CleanEditorServices, BuildEditorServices,
     }
 }
 
-task UploadArtifacts {
-    if ($env:TF_BUILD) {
-        # SYSTEM_PHASENAME is the Job name.
-        Copy-Item -Path PowerShell-insiders.vsix `
-            -Destination "$env:BUILD_ARTIFACTSTAGINGDIRECTORY/$($script:PackageJson.name)-$($script:PackageJson.version)-$env:SYSTEM_PHASENAME.vsix"
-    }
-}
-
 #endregion
 #region Restore tasks
 
@@ -145,15 +137,15 @@ task Package UpdateReadme, {
         throw "Unable to find PowerShell EditorServices"
     }
 
-    Write-Host "`n### Packaging PowerShell-insiders.vsix`n" -ForegroundColor Green
+    $packageName = "$($script:PackageJson.name)-$($script:PackageJson.version).vsix"
+    Write-Host "`n### Packaging $packageName`n" -ForegroundColor Green
     exec { & node ./node_modules/vsce/out/vsce package --no-gitHubIssueLinking }
 
-    # Change the package to have a static name for automation purposes
-    Move-Item -Force .\$($script:PackageJson.name)-$($script:PackageJson.version).vsix .\PowerShell-insiders.vsix
-
     if ($env:TF_BUILD) {
-        Copy-Item -Verbose -Recurse "./PowerShell-insiders.vsix" "$env:BUILD_ARTIFACTSTAGINGDIRECTORY/vscode-powershell/PowerShell-insiders.vsix"
-        Copy-Item -Verbose -Recurse "./scripts/Install-VSCode.ps1" "$env:BUILD_ARTIFACTSTAGINGDIRECTORY/vscode-powershell/Install-VSCode.ps1"
+        $artifactsPath = "$env:BUILD_ARTIFACTSTAGINGDIRECTORY/vscode-powershell/"
+        "./$packageName", "./scripts/Install-VSCode.ps1" | ForEach-Object {
+            Copy-Item -Verbose -Recurse $_ $artifactsPath
+        }
     }
 }
 
@@ -162,4 +154,4 @@ task Package UpdateReadme, {
 # The set of tasks for a release
 task Release Clean, Build, Package
 # The default task is to run the entire CI build
-task . CleanAll, BuildAll, Test, Package, UploadArtifacts
+task . CleanAll, BuildAll, Test, Package