Setup bundling and fix tasks

While we need to bundle the extension code with `eslint` we still have
to use `tsc` for the tests, which is annoying.

This also fixes are (already broken) VS Code launch tasks!

Author: andyleejordan

.vscode/launch.json

@@ -7,13 +7,11 @@
       "request": "launch",
       "runtimeExecutable": "${execPath}",
       "args": [
-        "--extensionDevelopmentPath=${workspaceRoot}"
+        "--disable-extensions",
+        "--extensionDevelopmentPath=${workspaceFolder}"
       ],
-      "stopOnEntry": false,
       "sourceMaps": true,
-      "outFiles": [
-        "${workspaceFolder}/out/src/**/*.js"
-      ],
+      "outFiles": [ "${workspaceFolder}/out/main.js" ],
       "preLaunchTask": "Build"
     },
     {
@@ -22,15 +20,15 @@
       "request": "launch",
       "runtimeExecutable": "${execPath}",
       "args": [
-        "--disable-extensions",
-        "ms-vscode.powershell-preview",
+        // The tests require Code be opened with a workspace, which exists in
+        // `test`, but this has to be passed as a CLI argument, not just `cwd`.
+        "${workspaceFolder}/test",
+        "--disableExtensions",
         "--extensionDevelopmentPath=${workspaceFolder}",
-        "--extensionTestsPath=${workspaceFolder}/out/test/testRunner.js",
-        "${workspaceFolder}/test"
-      ],
-      "outFiles": [
-        "${workspaceFolder}/out/**/*.js"
+        "--extensionTestsPath=${workspaceFolder}/out/test/index.js",
       ],
+      "sourceMaps": true,
+      "outFiles": [ "${workspaceFolder}/out/test/**/*.js" ],
       "preLaunchTask": "Build"
     },
     {

.vscodeignore

@@ -1,24 +1,27 @@
-.vscode/**
-.vscode-test/**
-vscode-powershell.build.ps1
-typings/**
-**/*.ts
+.github/
+.poshchan/
+.vscode/
+.vscode-test/
+.vsts-ci/
+logs/
+node_modules/
+out/
+scripts/
+sessions/
+src/
+test/
+tools/
+
+!out/main.js
+
+.editorconfig
+.gitattributes
 .gitignore
-tsconfig.json
-build/**
-bin/EditorServices.log
-bin/DebugAdapter.log
-bin/*.vshost.*
-bin/PowerShell/**
-logs/**
-out/test/**
-test/**
-sessions/**
-scripts/Install-VSCode.ps1
-tools/**
-.poshchan/**
-.github/**
-.vsts-ci/**
+.markdownlint.json
+.vscodeignore
 build.ps1
+extension-dev.code-workspace
+*.vsix
 tsconfig.json
 tslint.json
+vscode-powershell.build.ps1

package.json

@@ -25,7 +25,6 @@
     "type": "git",
     "url": "https://github.com/PowerShell/vscode-powershell.git"
   },
-  "main": "./out/src/main",
   "activationEvents": [
     "onDebugInitialConfigurations",
     "onDebugResolve:PowerShell",
@@ -79,9 +78,10 @@
   "extensionDependencies": [
     "vscode.powershell"
   ],
+  "main": "./out/main.js",
   "scripts": {
-    "compile": "tsc -v && tsc -p ./ && tslint -p ./",
-    "compile-watch": "tsc -watch -p ./",
+    "lint": "tslint --project tsconfig.json",
+    "build": "tsc --project tsconfig.json && esbuild ./src/main.ts --outdir=out --sourcemap --bundle --minify --external:vscode --platform=node",
     "test": "node ./out/test/runTests.js",
     "package": "vsce package --no-gitHubIssueLinking",
     "publish": "vsce publish"

tsconfig.json

@@ -1,16 +1,18 @@
 {
-    "compilerOptions": {
-        "rootDir": ".",
-        "module": "commonjs",
-        "target": "es6",
-        "outDir": "out",
-        "lib": [
-            "es2017",
-            "DOM"
-        ],
-        "sourceMap": true
-    },
-    "exclude": [
-        "node_modules"
-    ]
+  "compilerOptions": {
+    // NOTE: The TypeScript compiler is only used for building the tests (and
+    // the sources which the tests need). The extension is built with `esbuild`.
+    "module": "commonjs",
+    "outDir": "out",
+    "target": "ES6",
+    "lib": [ "ES6", "DOM" ],
+    "sourceMap": true,
+    "rootDir": ".",
+    // TODO: We need to enable stricter checking...
+    // "strict": true,
+    // "noImplicitReturns": true,
+    // "noFallthroughCasesInSwitch": true,
+    // "noUnusedParameters": true
+  },
+  "include": [ "src", "test" ],
 }

vscode-powershell.build.ps1

@@ -64,7 +64,17 @@ task CopyEditorServices -If { !(Test-Path ./modules/PowerShellEditorServices) -a
 
 task Build CopyEditorServices, Restore, {
     Write-Host "`n### Building vscode-powershell" -ForegroundColor Green
-    exec { & npm run compile }
+    # TODO: TSLint is deprecated and we need to switch to ESLint.
+    # https://github.com/PowerShell/vscode-powershell/pull/3331
+    exec { & npm run lint }
+
+    # TODO: When supported we should use `esbuild` for the tests too. Although
+    # we now use `esbuild` to transpile, bundle, and minify the extension, we
+    # still use `tsc` to transpile everything in `src` and `test` because the VS
+    # Code test runner expects individual files (and globs them at runtime).
+    # Unfortunately `esbuild` doesn't support emitting 1:1 files (yet).
+    # https://github.com/evanw/esbuild/issues/944
+    exec { & npm run build }
 }
 
 #endregion