Fix small bug with powerShellDefaultVersion warning (#4297)

andyleejordan · web-flow · commit d4f2164217bf · 2022-12-01T21:12:30.000Z
Missed a conditional.
diff --git a/src/session.ts b/src/session.ts
@@ -504,7 +504,7 @@ export class SessionManager implements Middleware {
 
             }
             foundPowerShell = defaultPowerShell ?? await powershellExeFinder.getFirstAvailablePowerShellInstallation();
-            if (defaultPowerShell === undefined && foundPowerShell !== undefined) {
+            if (wantedName !== "" && defaultPowerShell === undefined && foundPowerShell !== undefined) {
                 void this.logger.writeAndShowWarning(`The 'powerShellDefaultVersion' setting was '${wantedName}' but this was not found!`
                     + ` Instead using first available installation '${foundPowerShell.displayName}' at '${foundPowerShell.exePath}'!`);
             }

Original file line number	Diff line number	Diff line change
`@@ -504,7 +504,7 @@ export class SessionManager implements Middleware {`
`504`	`504`
`505`	`505`	`}`
`506`	`506`	`foundPowerShell = defaultPowerShell ?? await powershellExeFinder.getFirstAvailablePowerShellInstallation();`
`507`		`- if (defaultPowerShell === undefined && foundPowerShell !== undefined) {`
	`507`	`+ if (wantedName !== "" && defaultPowerShell === undefined && foundPowerShell !== undefined) {`
`508`	`508`	void this.logger.writeAndShowWarning(`The 'powerShellDefaultVersion' setting was '${wantedName}' but this was not found!`
`509`	`509`	+ ` Instead using first available installation '${foundPowerShell.displayName}' at '${foundPowerShell.exePath}'!`);
`510`	`510`	`}`