WIP: enable tslint and fix tslint warnings (#1148)

* Enable tslint - clean up main.ts

* Clean up tslint warings in rest of top-level ts files

* WIP - eliminate more tslint warnings

* Fix more tslint warnings

* More TSLINT cleanup

* More TSLINT warning cleanup

* Close to final on TSLINT cleanup

* Add recommended extensions.json

* Address PR feedback, manually tested

* Fix tslint warning on shadowed var name

Author: rkeithhill

.vscode/extensions.json

@@ -0,0 +1,10 @@
+{
+  // See http://go.microsoft.com/fwlink/?LinkId=827846
+  // for the documentation about the extensions.json format
+  "recommendations": [
+    "msjsdiag.debugger-for-chrome",
+    "ms-vscode.PowerShell",
+    "eg2.tslint",
+    "DavidAnson.vscode-markdownlint"
+  ]
+}

examples/.vscode/settings.json

@@ -3,4 +3,4 @@
     // Relative paths for this setting are always relative to the workspace root dir.
     "powershell.scriptAnalysis.settingsPath": "./PSScriptAnalyzerSettings.psd1",
     "files.defaultLanguage": "powershell"
-}
+}

package-lock.json

@@ -40,12 +40,13 @@
     "vscode-languageclient": "3.3.0"
   },
   "devDependencies": {
+    "@types/mocha": "^2.2.32",
     "@types/node": "^6.0.40",
+    "mocha": "^2.3.3",
+    "tslint": "^5.8.0",
     "typescript": "2.3.x",
     "vsce": "^1.18.0",
-    "vscode": "^1.1.0",
-    "mocha": "^2.3.3",
-    "@types/mocha": "^2.2.32"
+    "vscode": "^1.1.0"
   },
   "extensionDependencies": [
     "vscode.powershell"

package.json

@@ -3,14 +3,14 @@
  *--------------------------------------------------------*/
 
 import {
-    StatusBarItem,
+    Disposable,
     StatusBarAlignment,
+    StatusBarItem,
     ThemeColor,
-    Disposable,
     window} from "vscode";
 
 export function showAnimatedStatusBarMessage(text: string, hideWhenDone: Thenable<any>): Disposable {
-    let animatedStatusBarItem: AnimatedStatusBarItem = new AnimatedStatusBarItem(text);
+    const animatedStatusBarItem: AnimatedStatusBarItem = new AnimatedStatusBarItem(text);
     animatedStatusBarItem.show(hideWhenDone);
     return animatedStatusBarItem;
 }
@@ -73,7 +73,7 @@ class AnimatedStatusBarItem implements StatusBarItem {
         this.counter = 0;
         this.suffixStates = ["  ", ".  ", ".. ", "..."];
         this.maxCount = this.suffixStates.length;
-        this.timerInterval = ((1/this.maxCount) * 1000) / this.animationRate;
+        this.timerInterval = ((1 / this.maxCount) * 1000) / this.animationRate;
         this.elapsedTime = 0;
     }
 
@@ -121,4 +121,4 @@ class AnimatedStatusBarItem implements StatusBarItem {
     private stop(): void {
         clearInterval(this.intervalId);
     }
-}
+}