WIP - eliminate more tslint warnings

Author: rkeithhill

examples/.vscode/settings.json

@@ -3,4 +3,4 @@
     // Relative paths for this setting are always relative to the workspace root dir.
     "powershell.scriptAnalysis.settingsPath": "./PSScriptAnalyzerSettings.psd1",
     "files.defaultLanguage": "powershell"
-}
+}

src/controls/animatedStatusBar.ts

@@ -3,14 +3,14 @@
  *--------------------------------------------------------*/
 
 import {
-    StatusBarItem,
+    Disposable,
     StatusBarAlignment,
+    StatusBarItem,
     ThemeColor,
-    Disposable,
     window} from "vscode";
 
 export function showAnimatedStatusBarMessage(text: string, hideWhenDone: Thenable<any>): Disposable {
-    let animatedStatusBarItem: AnimatedStatusBarItem = new AnimatedStatusBarItem(text);
+    const animatedStatusBarItem: AnimatedStatusBarItem = new AnimatedStatusBarItem(text);
     animatedStatusBarItem.show(hideWhenDone);
     return animatedStatusBarItem;
 }
@@ -73,7 +73,7 @@ class AnimatedStatusBarItem implements StatusBarItem {
         this.counter = 0;
         this.suffixStates = ["  ", ".  ", ".. ", "..."];
         this.maxCount = this.suffixStates.length;
-        this.timerInterval = ((1/this.maxCount) * 1000) / this.animationRate;
+        this.timerInterval = ((1 / this.maxCount) * 1000) / this.animationRate;
         this.elapsedTime = 0;
     }
 
@@ -121,4 +121,4 @@ class AnimatedStatusBarItem implements StatusBarItem {
     private stop(): void {
         clearInterval(this.intervalId);
     }
-}
+}

src/controls/checkboxQuickPick.ts

@@ -4,96 +4,95 @@
 
 import vscode = require("vscode");
 
-var confirmItemLabel: string = "$(checklist) Confirm";
-var checkedPrefix: string = "[ $(check) ]";
-var uncheckedPrefix: string = "[     ]";
-var defaultPlaceHolder: string = "Select 'Confirm' to confirm or press 'Esc' key to cancel";
+const confirmItemLabel: string = "$(checklist) Confirm";
+const checkedPrefix: string = "[ $(check) ]";
+const uncheckedPrefix: string = "[     ]";
+const defaultPlaceHolder: string = "Select 'Confirm' to confirm or press 'Esc' key to cancel";
 
-export interface CheckboxQuickPickItem {
+export interface ICheckboxQuickPickItem {
     label: string;
     description?: string;
     isSelected: boolean;
 }
 
-export interface CheckboxQuickPickOptions {
+export interface ICheckboxQuickPickOptions {
     confirmPlaceHolder: string;
 }
 
-var defaultOptions:CheckboxQuickPickOptions = { confirmPlaceHolder: defaultPlaceHolder};
+const defaultOptions: ICheckboxQuickPickOptions = { confirmPlaceHolder: defaultPlaceHolder};
 
 export function showCheckboxQuickPick(
-    items: CheckboxQuickPickItem[],
-    options: CheckboxQuickPickOptions = defaultOptions): Thenable<CheckboxQuickPickItem[]> {
+    items: ICheckboxQuickPickItem[],
+    options: ICheckboxQuickPickOptions = defaultOptions): Thenable<ICheckboxQuickPickItem[]> {
 
     return showInner(items, options).then(
         (selectedItem) => {
             // We're mutating the original item list so just return it for now.
             // If 'selectedItem' is undefined it means the user cancelled the
             // inner showQuickPick UI so pass the undefined along.
-            return selectedItem != undefined ? items : undefined;
-        })
+            return selectedItem !== undefined ? items : undefined;
+        });
 }
 
-function getQuickPickItems(items: CheckboxQuickPickItem[]): vscode.QuickPickItem[] {
+function getQuickPickItems(items: ICheckboxQuickPickItem[]): vscode.QuickPickItem[] {
 
-    let quickPickItems: vscode.QuickPickItem[] = [];
+    const quickPickItems: vscode.QuickPickItem[] = [];
     quickPickItems.push({ label: confirmItemLabel, description: "" });
 
-    items.forEach(item =>
+    items.forEach((item) =>
         quickPickItems.push({
                 label: convertToCheckBox(item),
-                description: item.description
+                description: item.description,
         }));
 
     return quickPickItems;
 }
 
 function showInner(
-    items: CheckboxQuickPickItem[],
-    options: CheckboxQuickPickOptions): Thenable<vscode.QuickPickItem> {
+    items: ICheckboxQuickPickItem[],
+    options: ICheckboxQuickPickOptions): Thenable<vscode.QuickPickItem> {
 
-    var quickPickThenable: Thenable<vscode.QuickPickItem> =
+    const quickPickThenable: Thenable<vscode.QuickPickItem> =
         vscode.window.showQuickPick(
             getQuickPickItems(items),
             {
                 ignoreFocusOut: true,
                 matchOnDescription: true,
-                placeHolder: options.confirmPlaceHolder
+                placeHolder: options.confirmPlaceHolder,
             });
 
     return quickPickThenable.then(
         (selection) => {
             if (!selection) {
-                //return Promise.reject<vscode.QuickPickItem>("showCheckBoxQuickPick cancelled")
                 return Promise.resolve<vscode.QuickPickItem>(undefined);
             }
 
             if (selection.label === confirmItemLabel) {
                 return selection;
             }
 
-            let index: number = getItemIndex(items, selection.label);
+            const index: number = getItemIndex(items, selection.label);
 
             if (index >= 0) {
                 toggleSelection(items[index]);
-            }
-            else {
+            } else {
+                // tslint:disable-next-line:no-console
                 console.log(`Couldn't find CheckboxQuickPickItem for label '${selection.label}'`);
             }
 
             return showInner(items, options);
         });
 }
 
-function getItemIndex(items: CheckboxQuickPickItem[], itemLabel: string): number {
-    var trimmedLabel = itemLabel.substr(itemLabel.indexOf("]") + 2);
-    return items.findIndex(item => item.label === trimmedLabel);
+function getItemIndex(items: ICheckboxQuickPickItem[], itemLabel: string): number {
+    const trimmedLabel = itemLabel.substr(itemLabel.indexOf("]") + 2);
+    return items.findIndex((item) => item.label === trimmedLabel);
 }
 
-function toggleSelection(item: CheckboxQuickPickItem): void {
+function toggleSelection(item: ICheckboxQuickPickItem): void {
     item.isSelected = !item.isSelected;
 }
 
-function convertToCheckBox(item: CheckboxQuickPickItem): string {
+function convertToCheckBox(item: ICheckboxQuickPickItem): string {
     return `${item.isSelected ? checkedPrefix : uncheckedPrefix} ${item.label}`;
-}
+}

src/features/CodeActions.ts

@@ -2,17 +2,17 @@
  * Copyright (C) Microsoft Corporation. All rights reserved.
  *--------------------------------------------------------*/
 
-import vscode = require('vscode');
-import { LanguageClient } from 'vscode-languageclient';
+import vscode = require("vscode");
+import { LanguageClient } from "vscode-languageclient";
 import Window = vscode.window;
-import { IFeature } from '../feature';
+import { IFeature } from "../feature";
 
 export class CodeActionsFeature implements IFeature {
     private command: vscode.Disposable;
     private languageClient: LanguageClient;
 
     constructor() {
-        this.command = vscode.commands.registerCommand('PowerShell.ApplyCodeActionEdits', (edit: any) => {
+        this.command = vscode.commands.registerCommand("PowerShell.ApplyCodeActionEdits", (edit: any) => {
             Window.activeTextEditor.edit((editBuilder) => {
                 editBuilder.replace(
                     new vscode.Range(
@@ -25,11 +25,11 @@ export class CodeActionsFeature implements IFeature {
         });
     }
 
-    public setLanguageClient(languageclient: LanguageClient) {
-        this.languageClient = languageclient;
-    }
-
     public dispose() {
         this.command.dispose();
     }
-}
+
+    public setLanguageClient(languageclient: LanguageClient) {
+        this.languageClient = languageclient;
+    }
+}