Skip to content

Commit 5775d52

Browse files
committed
Enable 'useUnknownInCatchVariables'
1 parent 3e9db04 commit 5775d52

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/session.ts

+8-9
Original file line numberDiff line numberDiff line change
@@ -450,17 +450,16 @@ export class SessionManager implements Middleware {
450450

451451
try {
452452
this.sessionDetails = await languageServerProcess.start("EditorServices");
453-
} catch (error) {
454-
this.log.write("PowerShell process failed to start.");
455-
await this.setSessionFailure("PowerShell process failed to start: ", error);
453+
} catch (err) {
454+
await this.setSessionFailure("PowerShell process failed to start: ", err instanceof Error ? err.message : "unknown");
456455
}
457456

458457
if (this.sessionDetails?.status === "started") {
459458
this.log.write("Language server started.");
460459
try {
461460
await this.startLanguageClient(this.sessionDetails);
462-
} catch (error) {
463-
await this.setSessionFailure("Language client failed to start: ", error);
461+
} catch (err) {
462+
await this.setSessionFailure("Language client failed to start: ", err instanceof Error ? err.message : "unknown");
464463
}
465464
} else if (this.sessionDetails?.status === "failed") {
466465
if (this.sessionDetails.reason === "unsupported") {
@@ -687,8 +686,8 @@ Type 'help' to get help.
687686

688687
try {
689688
await this.languageClient.start();
690-
} catch (error) {
691-
await this.setSessionFailure("Could not start language service: ", error);
689+
} catch (err) {
690+
await this.setSessionFailure("Could not start language service: ", err instanceof Error ? err.message : "unknown");
692691
return;
693692
}
694693

@@ -727,9 +726,9 @@ Type 'help' to get help.
727726
localVersion!,
728727
this.versionDetails!.architecture,
729728
release);
730-
} catch (error) {
729+
} catch (err) {
731730
// Best effort. This probably failed to fetch the data from GitHub.
732-
this.log.writeWarning(error.message);
731+
this.log.writeWarning(err instanceof Error ? err.message : "unknown");
733732
}
734733
}
735734

tsconfig.json

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"strictFunctionTypes": true,
1818
"strictNullChecks": true,
1919
"strictPropertyInitialization": true,
20+
"useUnknownInCatchVariables": true,
2021
"noImplicitReturns": true,
2122
"noFallthroughCasesInSwitch": true,
2223
"noUnusedParameters": true

0 commit comments

Comments
 (0)