Skip to content

Commit 3d92d5d

Browse files
Skip UpdatePowerShell tests in CI on macOS (#2479)
1 parent 5483758 commit 3d92d5d

File tree

2 files changed

+20
-14
lines changed

2 files changed

+20
-14
lines changed

src/features/UpdatePowerShell.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export class GitHubReleaseInformation {
4545

4646
if (!response.ok) {
4747
const json = await response.json();
48-
throw json.message || json || "response was not ok.";
48+
throw new Error(json.message || json || "response was not ok.");
4949
}
5050

5151
// For preview, we grab all the releases and then grab the first prerelease.

test/features/UpdatePowerShell.test.ts

+19-13
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,24 @@
55
import * as assert from "assert";
66
import { GitHubReleaseInformation } from "../../src/features/UpdatePowerShell";
77

8-
suite("UpdatePowerShell tests", () => {
9-
test("Can get the latest version", async () => {
10-
const release: GitHubReleaseInformation = await GitHubReleaseInformation.FetchLatestRelease(false);
11-
assert.strictEqual(release.isPreview, false, "expected to not be preview.");
12-
assert.strictEqual(release.version.prerelease.length === 0, true, "expected to not have preview in version.");
13-
assert.strictEqual(release.assets.length > 0, true, "expected to have assets.");
14-
});
8+
// Due to Azure DevOps using the same macOS instances, the macOS builds hit
9+
// the GitHub API rate limit often. Let's skip these tests on macOS until
10+
// they are hooked up to only run on release.
11+
if (process.env.TF_BUILD && process.platform === "win32") {
12+
suite("UpdatePowerShell tests", () => {
13+
test("Can get the latest version", async () => {
14+
const release: GitHubReleaseInformation = await GitHubReleaseInformation.FetchLatestRelease(false);
15+
assert.strictEqual(release.isPreview, false, "expected to not be preview.");
16+
assert.strictEqual(
17+
release.version.prerelease.length === 0, true, "expected to not have preview in version.");
18+
assert.strictEqual(release.assets.length > 0, true, "expected to have assets.");
19+
});
1520

16-
test("Can get the latest preview version", async () => {
17-
const release: GitHubReleaseInformation = await GitHubReleaseInformation.FetchLatestRelease(true);
18-
assert.strictEqual(release.isPreview, true, "expected to be preview.");
19-
assert.strictEqual(release.version.prerelease.length > 0, true, "expected to have preview in version.");
20-
assert.strictEqual(release.assets.length > 0, true, "expected to have assets.");
21+
test("Can get the latest preview version", async () => {
22+
const release: GitHubReleaseInformation = await GitHubReleaseInformation.FetchLatestRelease(true);
23+
assert.strictEqual(release.isPreview, true, "expected to be preview.");
24+
assert.strictEqual(release.version.prerelease.length > 0, true, "expected to have preview in version.");
25+
assert.strictEqual(release.assets.length > 0, true, "expected to have assets.");
26+
});
2127
});
22-
});
28+
}

0 commit comments

Comments
 (0)