Skip to content

Commit 1f33327

Browse files
committed
Remove unused INotebooksSettings
This feature never made it out of preview.
1 parent aa9c5fa commit 1f33327

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

src/settings.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ export interface ISettings {
9797
pester: IPesterSettings;
9898
buttons?: IButtonSettings;
9999
cwd?: string;
100-
notebooks?: INotebooksSettings;
101100
enableReferencesCodeLens?: boolean;
102101
analyzeOpenDocumentsOnly?: boolean;
103102
}
@@ -131,10 +130,6 @@ export interface IButtonSettings {
131130
showPanelMovementButtons?: boolean;
132131
}
133132

134-
export interface INotebooksSettings {
135-
saveMarkdownCellsAs?: CommentType;
136-
}
137-
138133
// TODO: This could probably be async, and call `validateCwdSetting()` directly.
139134
export function load(): ISettings {
140135
const configuration: vscode.WorkspaceConfiguration =
@@ -218,10 +213,6 @@ export function load(): ISettings {
218213
debugOutputVerbosity: "Diagnostic",
219214
};
220215

221-
const defaultNotebooksSettings: INotebooksSettings = {
222-
saveMarkdownCellsAs: CommentType.BlockComment,
223-
};
224-
225216
// TODO: I believe all the defaults can be removed, as the `package.json` should supply them (and be the source of truth).
226217
return {
227218
startAutomatically:
@@ -260,8 +251,6 @@ export function load(): ISettings {
260251
configuration.get<IPesterSettings>("pester", defaultPesterSettings),
261252
buttons:
262253
configuration.get<IButtonSettings>("buttons", defaultButtonSettings),
263-
notebooks:
264-
configuration.get<INotebooksSettings>("notebooks", defaultNotebooksSettings),
265254
startAsLoginShell:
266255
// We follow the same convention as VS Code - https://github.com/microsoft/vscode/blob/ff00badd955d6cfcb8eab5f25f3edc86b762f49f/src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts#L105-L107
267256
// "Unlike on Linux, ~/.profile is not sourced when logging into a macOS session. This

0 commit comments

Comments
 (0)