Fix detection of valid PS ext for debugging. (#642)

* Fix detection of valid PS ext for debugging.

Was previously only allowing lower case ps1 and psm1.  I'm assuming that on *nix file systems, that PowerShell allows all variations of ps1,PS1,pS1,Ps1 as valid script extensions.

Fix #641

* Fix issue with debugging unsaved file.

* Use same term used in the command palette.

* Shorten error message based on juneb feedback.

Author: rkeithhill

src/features/DebugSession.ts

@@ -42,24 +42,37 @@ export class DebugSessionFeature implements IFeature {
             // is not a file that can be debugged by PowerShell
             if (config.script === "${file}") {
                 let currentDocument = vscode.window.activeTextEditor.document;
-                let ext =
-                    currentDocument.fileName.substr(
-                        currentDocument.fileName.lastIndexOf('.') + 1);
-
-                if ((currentDocument.languageId !== 'powershell') ||
-                    (!currentDocument.isUntitled) && (ext !== "ps1" && ext !== "psm1")) {
-                    let path = currentDocument.fileName;
-                    let workspaceRootPath = vscode.workspace.rootPath;
-                    if (currentDocument.fileName.startsWith(workspaceRootPath)) {
-                        path = currentDocument.fileName.substring(vscode.workspace.rootPath.length + 1);
-                    }
 
-                    let msg = "'" + path + "' is a file type that cannot be debugged by the PowerShell debugger.";
-                    vscode.window.showErrorMessage(msg);
-                    return;
+                if (currentDocument.isUntitled) {
+                    if (currentDocument.languageId === 'powershell') {
+                        config.script = currentDocument.uri.toString();
+                    }
+                    else {
+                        let msg = "To debug '" + currentDocument.fileName +
+                                  "', change the document's language mode to PowerShell or save the file with a PowerShell extension.";
+                        vscode.window.showErrorMessage(msg);
+                        return;
+                    }
                 }
-                else if (currentDocument.isUntitled) {
-                    config.script = currentDocument.uri.toString();
+                else {
+                    let isValidExtension = false;
+                    let extIndex = currentDocument.fileName.lastIndexOf('.');
+                    if (extIndex !== -1) {
+                        let ext = currentDocument.fileName.substr(extIndex + 1).toUpperCase();
+                        isValidExtension = (ext === "PS1" || ext === "PSM1");
+                    }
+
+                    if ((currentDocument.languageId !== 'powershell') || !isValidExtension) {
+                        let path = currentDocument.fileName;
+                        let workspaceRootPath = vscode.workspace.rootPath;
+                        if (currentDocument.fileName.startsWith(workspaceRootPath)) {
+                            path = currentDocument.fileName.substring(vscode.workspace.rootPath.length + 1);
+                        }
+
+                        let msg = "'" + path + "' is a file type that cannot be debugged by the PowerShell debugger.";
+                        vscode.window.showErrorMessage(msg);
+                        return;
+                    }
                 }
             }
         }