Skip to content

Commit 1046278

Browse files
committed
Remove CodeFoldingSettings class
As the client-side folder was removed eons ago.
1 parent 1cafa17 commit 1046278

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/settings.ts

+8-6
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,14 @@ import utils = require("./utils");
66
import os = require("os");
77
import { Logger } from "./logging";
88

9+
// TODO: Quite a few of these settings are unused in the client and instead
10+
// exist just for the server. Those settings do not need to be represented in
11+
// this class, as the LSP layers take care of communicating them. Frankly, this
12+
// class is over-engineered and seems to have originally been created to avoid
13+
// using vscode.workspace.getConfiguration() directly. It wasn't a bad idea to
14+
// keep things organized so consistent...but it ended up failing in execution.
15+
// Perhaps we just get rid of this entirely?
16+
917
// eslint-disable-next-line @typescript-eslint/no-extraneous-class
1018
class PartialSettings { }
1119

@@ -22,7 +30,6 @@ export class Settings extends PartialSettings {
2230
scriptAnalysis = new ScriptAnalysisSettings();
2331
debugging = new DebuggingSettings();
2432
developer = new DeveloperSettings();
25-
codeFolding = new CodeFoldingSettings();
2633
codeFormatting = new CodeFormattingSettings();
2734
integratedConsole = new IntegratedConsoleSettings();
2835
sideBar = new SideBarSettings();
@@ -65,11 +72,6 @@ export enum CommentType {
6572

6673
export type PowerShellAdditionalExePathSettings = Record<string, string>;
6774

68-
class CodeFoldingSettings extends PartialSettings {
69-
enable = true;
70-
showLastLine = true;
71-
}
72-
7375
class CodeFormattingSettings extends PartialSettings {
7476
autoCorrectAliases = false;
7577
avoidSemicolonsAsLineTerminators = false;

0 commit comments

Comments
 (0)