Skip to content

Commit 05091bb

Browse files
committed
Remove unused telemetry
We never actually used (or even received) the telemetry from the walkthrough survey, ergo we shouldn't be sending it.
1 parent 407f649 commit 05091bb

File tree

2 files changed

+5
-19
lines changed

2 files changed

+5
-19
lines changed

package.json

-13
Original file line numberDiff line numberDiff line change
@@ -301,11 +301,6 @@
301301
"title": "Invoke Registered Editor Command",
302302
"category": "PowerShell"
303303
},
304-
{
305-
"command": "PowerShell.WalkthroughTelemetry",
306-
"title": "Walkthrough Telemetry",
307-
"category": "PowerShell"
308-
},
309304
{
310305
"command": "PowerShell.ClosePanel",
311306
"title": "Close panel",
@@ -1119,14 +1114,6 @@
11191114
"markdown": "media/walkthrough.md"
11201115
},
11211116
"description": "Now you are ready to start using the PowerShell Extension on your own and explore more resources!\n📚 See the PowerShell Extension's [documentation](https://docs.microsoft.com/en-us/powershell/scripting/dev-cross-plat/vscode/using-vscode?view=powershell-7.2)\nℹ️ View Visual Studio Code's [documentation](https://code.visualstudio.com/docs/languages/powershell)\n🔌 Plug into the [PowerShell Community](https://docs.microsoft.com/en-us/powershell/scripting/community/community-support?view=powershell-7.2)\n📄 Take a look at our [Release Notes](https://docs.microsoft.com/en-us/powershell/scripting/whats-new/what-s-new-in-powershell-73?view=powershell-7.2)"
1122-
},
1123-
{
1124-
"id": "feedback",
1125-
"title": "Share your feedback",
1126-
"media": {
1127-
"markdown": "media/walkthrough.md"
1128-
},
1129-
"description": "How has this walkthrough affected your confidence level when using the PowerShell Extension?\n[I feel less confident](command:PowerShell.WalkthroughTelemetry?%7B%22satisfaction%22%3A3%7D)\n[My confidence has not been affected](command:PowerShell.WalkthroughTelemetry?%7B%22satisfaction%22%3A2%7D)\n[I feel more confident](command:PowerShell.WalkthroughTelemetry?%7B%22satisfaction%22%3A1%7D)"
11301117
}
11311118
]
11321119
}

src/session.ts

+5-6
Original file line numberDiff line numberDiff line change
@@ -470,12 +470,7 @@ export class SessionManager implements Middleware {
470470
vscode.commands.registerCommand(this.ShowSessionMenuCommandName, async () => { await this.showSessionMenu(); }),
471471
vscode.workspace.onDidChangeConfiguration(async () => { await this.onConfigurationUpdated(); }),
472472
vscode.commands.registerCommand(
473-
"PowerShell.ShowSessionConsole", (isExecute?: boolean) => { this.showSessionTerminal(isExecute); }),
474-
vscode.commands.registerCommand(
475-
"PowerShell.WalkthroughTelemetry", (satisfaction: number) => {
476-
this.sendTelemetryEvent("powershellWalkthroughSatisfaction", undefined, { level: satisfaction });
477-
}
478-
)
473+
"PowerShell.ShowSessionConsole", (isExecute?: boolean) => { this.showSessionTerminal(isExecute); })
479474
];
480475
}
481476

@@ -645,6 +640,8 @@ export class SessionManager implements Middleware {
645640
// TODO: We should only turn this on in preview.
646641
languageClient.registerProposedFeatures();
647642

643+
// NOTE: We don't currently send any events from PSES, but may again in
644+
// the future so we're leaving this side wired up.
648645
languageClient.onTelemetry((event) => {
649646
const eventName: string = event.eventName ? event.eventName : "PSESEvent";
650647
// eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -753,6 +750,8 @@ Type 'help' to get help.
753750
const versionDetails = await this.languageClient?.sendRequest(
754751
PowerShellVersionRequestType, timeout.token);
755752

753+
// This is pretty much the only telemetry event we care about.
754+
// TODO: We actually could send this earlier from PSES itself.
756755
this.sendTelemetryEvent("powershellVersionCheck",
757756
{ powershellVersion: versionDetails?.version ?? "unknown" });
758757

0 commit comments

Comments
 (0)