Provide Run Selection button in Editor Title Menu #2224
Conversation
|
@jpogran can you use these svgs (there's a light and dark)? They look like this: I got some help from @isabelacmor mashing the vscode icons together 😅 |
jpogran
force-pushed
the
gh-2215-run-selection-button
branch
from
7c1ad00 to
cfde9ff
Compare
|
Updated with the new icon. Nice work 😄
|
jpogran
changed the title
|
Looks good! Hmm I'm thinking it might be nice to have another button to the left of it that's just the play button, just like the ISE. That can just launch the debugger since that's what F5 does today. @rjmholt @SydneyhSmith what do you think? |
Agreed! |
|
I still need to checkout this branch and take a look at it, but it looks good so far! |
|
@jpogran is that something you're interested in taking on? You can just use the play button you had previously and then just look up the command that it needs to execute to start debugging. Let me know if you need help finding the command. I typically find it on the keybinding menu by hovering over the keybinding. |
|
Sure, will hook that up tomorrow |
This commit adds a editor title menu button for the `powershell.RunSelection` command in the primary navigation group, and a custom `play` icon based on ones from the https://github.com/microsoft/vscode-icons repo. This shows the button in the visible part of the menu when a PowerShell file is open.
jpogran
force-pushed
the
gh-2215-run-selection-button
branch
from
cfde9ff to
99e08fd
Compare
|
@TylerLeonhardt I registered the command in the |
|
@jpogran this is looking great to me, thanks for the work! |
package.json
Outdated
| @@ -161,10 +161,23 @@ | |||
| }, | |||
| "category": "PowerShell" | |||
| }, | |||
| { | |||
| "command": "PowerShell.Run", | |||
There was a problem hiding this comment.
@jpogran is there a reason this can't just be workbench.action.debug.start?
There was a problem hiding this comment.
No, I just had it in my head you need to make a command for anything you were going to use 😅 . Works fine as you suggest
This commit adds a editor title menu button for the `powershell.Run` command which maps to the builtin VS Code Debug start command. It places it in the primary navigation group, and the uses `run` icon from the https://github.com/microsoft/vscode-icons repo. This shows the button in the visible part of the menu when a PowerShell file is open.
jpogran
force-pushed
the
gh-2215-run-selection-button
branch
from
99e08fd to
5905089
Compare
|
ignore the macOS failure... I need to fix that. |
|
It's great to see the reaction to this, and the two approvals. Is there anything waiting on me to do to get this merged? |
|
Nope! Thank you for your contribution! People are so pumped for this. |
* Provide Run Selection button in Editor Title Menu This commit adds a editor title menu button for the `powershell.RunSelection` command in the primary navigation group, and a custom `play` icon based on ones from the https://github.com/microsoft/vscode-icons repo. This shows the button in the visible part of the menu when a PowerShell file is open.
PR Summary
This adds a editor title menu button for the
powershell.RunSelectioncommand in the primary navigation group, and therunicon from the https://github.com/microsoft/vscode-icons repo.This shows the button in the visible part of the menu when a PowerShell file is open.
This PR is marked as WIP because the icon chosen is the closest approximation I could find in the vscode suggested icon library, but if there is another one that is preferred I can change it to that.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.NAWIP:to the beginning of the title and remove the prefix when the PR is readyThis PR fixes #2215