fix change session by moving to async/await promise #1927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
approved these changes
Apr 28, 2019
rjmholt
approved these changes
Apr 28, 2019
There was a problem hiding this comment.
Wish I knew as well, but the important part is that @TylerLeonhardt has added a test so we can trust that the code knows itself
TylerLeonhardt
added a commit
to TylerLeonhardt/vscode-powershell
that referenced
this pull request
May 2, 2019
4 tasks
TylerLeonhardt
added a commit
that referenced
this pull request
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I'll be honest... I don't really understand why this fixed the issue...
I think it's because we use to just return the Thenable where as now we're actually awaiting the settings update... but idk... in my eyes they seem equivalent.
Also, the test I've added passes in both scenarios even though the test does a good job emulating the environment...
I can only deduce that this is a race condition with vscode updating settings in the true vscode environment (instead of test harness).
With all that said... this does consistently fix the issue - and async/await is better anyway.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready