Skip to content

Small update to Azure Data Studio MP ReadMe #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 18, 2019

Conversation

SQLvariant
Copy link
Contributor

@SQLvariant SQLvariant commented Apr 17, 2019

PR Summary

Removed the -AllowPrerelease parameter since it is no longer necessary.
Also updated the Get-SqlInstance sample output with the additional properties now being returned.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

SQLvariant and others added 13 commits March 12, 2019 13:24
Added examples specific to the official SqlServer PowerShell module, to help customers get started.
[ignore] initial readme for Azure Data Studio marketplace (PowerShell#1785)
Updated the format of the code examples.
Moved location of SQL PowerShell Examples to be after Example Scripts.
Fixed typo in description.
Commas.
Pulling changes from PowerShell/vscode-powershell back into my repo
Removed the  -AllowPrerelease parameter since it is no longer necessary.  Also updated the Get-SqlInstance sample output with the additional properties now being returned.
@rjmholt rjmholt requested a review from TylerLeonhardt April 17, 2019 21:51
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt
Copy link
Member

@yualan @stevestein FYI README update.

@TylerLeonhardt TylerLeonhardt merged commit 861b999 into PowerShell:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants